-
Notifications
You must be signed in to change notification settings - Fork 747
dns/bind: Forwarding feature expansion #4894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benyamin-codez
wants to merge
1
commit into
opnsense:master
Choose a base branch
from
benyamin-codez:bind-forwarding-feature-expansion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
dns/bind: Forwarding feature expansion #4894
benyamin-codez
wants to merge
1
commit into
opnsense:master
from
benyamin-codez:bind-forwarding-feature-expansion
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2025
benyamin-codez
commented
Aug 15, 2025
dns/bind/src/opnsense/mvc/app/controllers/OPNsense/Bind/forms/dialogEditBindForwardDomain.xml
Outdated
Show resolved
Hide resolved
2da9b7f to
471d1fb
Compare
benyamin-codez
commented
Aug 15, 2025
benyamin-codez
commented
Aug 15, 2025
fichtner
reviewed
Aug 15, 2025
dns/bind/src/opnsense/mvc/app/controllers/OPNsense/Bind/forms/dialogEditBindForwardDomain.xml
Outdated
Show resolved
Hide resolved
471d1fb to
a2bb5b8
Compare
Contributor
Author
|
Should be right to go methinks... 8^d |
benyamin-codez
commented
Aug 15, 2025
dns/bind/src/opnsense/mvc/app/controllers/OPNsense/Bind/forms/dialogEditBindForwardDomain.xml
Show resolved
Hide resolved
Expands the forwarding feature set by:
1. Adding global "forward only" option to forwarders
2. Adding "forward only" option to forward zones
3. Improving forward zone dialog help expansion and reformatting
4. Bumps model versions:
* General to v1.0.13
* Domain to v1.1.3
Signed-off-by: benyamin-codez <[email protected]>
a2bb5b8 to
ce24078
Compare
Contributor
Author
|
Removed superfluous help comment and amended commit message to detail model version bumps. This should be good to go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the forwarding feature set by:
Split from PR #4892.
Resolves #4890