Firewall: Rules [new]: Fix handling of interfacenot, evaluate as floating rules in correct prio_group #9426
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting rules in correct prio_group
fichtner
approved these changes
Nov 19, 2025
Member
fichtner
left a comment
fichtner
left a comment
There was a problem hiding this comment.
looks-like-it-does-the-thing type of approval
Monviech
force-pushed
the
firewall-interfacenot-floating
branch
from
66de53d to
df0c802
Compare
Member
Author
|
I fixed something small and now it reflects reality in my test: Empty Interface, Inverted Group, Inverted Interface, Multiple Interface -> All in floating 
@fichtner Should I wait on this one or is it okay for master? |
fichtner
reviewed
Nov 25, 2025
src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
Show resolved
Hide resolved
AdSchellevis
requested changes
Nov 25, 2025
src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
Show resolved
Hide resolved
| // floating: empty, multiple, or inverted interface | ||
| (string)$this->interfacenot === "1" || | ||
| (strpos($interface, ",")) !== false || | ||
| empty($interface) |
Member
There was a problem hiding this comment.
this doesn't seem to match our actual sorting
core/src/etc/inc/filter.lib.inc
Lines 675 to 681 in c6eaefc
Member
There was a problem hiding this comment.
be0b18930f36f9 says it's a floating rule pinned to one interface so this seems correct?
fichtner
reviewed
Nov 25, 2025
src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
Outdated
Show resolved
Hide resolved
…ontroller.php Co-authored-by: Franco Fichtner <[email protected]>
…ontroller.php Co-authored-by: Franco Fichtner <[email protected]>
fichtner
reviewed
Dec 2, 2025
src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
Outdated
Show resolved
Hide resolved
…ontroller.php Co-authored-by: Franco Fichtner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9425
A bit unsure if I got all spots, but this seems to work.
@AdSchellevis please correct this one as needed.