Firewall: Groups - missing lock while refactoring config, closes #8766

AdSchellevis · AdSchellevis · commit f64287f0484e · 2025-06-06T19:36:19.000+02:00
diff --git a/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/GroupController.php b/src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/GroupController.php
@@ -63,6 +63,7 @@ public function searchItemAction()
     public function setItemAction($uuid)
     {
         $refactored = false;
+        Config::getInstance()->lock();
         $node = $this->getModel()->getNodeByReference('ifgroupentry.' . $uuid);
         $old_name = $node != null ? (string)$node->ifname : null;
         if ($old_name !== null && $this->request->isPost() && $this->request->hasPost("group")) {

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ public function searchItemAction()`
`63`	`63`	`public function setItemAction($uuid)`
`64`	`64`	`{`
`65`	`65`	`$refactored = false;`
	`66`	`+ Config::getInstance()->lock();`
`66`	`67`	`$node = $this->getModel()->getNodeByReference('ifgroupentry.' . $uuid);`
`67`	`68`	`$old_name = $node != null ? (string)$node->ifname : null;`
`68`	`69`	`if ($old_name !== null && $this->request->isPost() && $this->request->hasPost("group")) {`