Apply suggested changes from drgrice1 in PR review.

Author: somiaj

lib/WeBWorK/AchievementItems.pm

@@ -105,7 +105,7 @@ sub UserItems ($c, $userName, $set, $records) {
 				$achievementItem->{count}--;
 				$globalUserAchievement->frozen_hash(nfreeze_base64($globalData));
 				$db->putGlobalUserAchievement($globalUserAchievement);
-				$c->addgoodmessage($c->maketext('[_1] succesffuly used. [_2]', $achievementItem->name, $message));
+				$c->addgoodmessage($c->maketext('[_1] successfuly used. [_2]', $achievementItem->name, $message));
 			}
 		}
 
@@ -154,13 +154,19 @@ sub form_popup_menu_row ($c, %options) {
 	$params{label_attr}{class} //= 'col-form-label';
 	$params{menu_attr}{class}  //= 'form-select';
 
-	unshift(@{ $params{values} }, [ $params{first_item} => '' ]) if $params{first_item};
+	unshift(@{ $params{values} }, [ $params{first_item} => '', disabled => undef, selected => undef ])
+		if $params{first_item};
 
 	my $row_contents = $c->tag(
 		'div',
 		class => 'form-floating',
 		$c->c(
-			$c->select_field($params{id} => $params{values}, %{ $params{menu_attr} }),
+			$c->select_field(
+				$params{id} => $params{values},
+				id => $params{id},
+				required => undef,
+				%{ $params{menu_attr} }
+			),
 			$c->label_for($params{id} => $params{label_text}, %{ $params{label_attr} })
 		)->join('')
 	);

lib/WeBWorK/AchievementItems/ExtendDueDate.pm

@@ -83,7 +83,7 @@ sub use_item ($self, $set, $records, $c) {
 	$db->putUserSet($userSet);
 
 	return $c->maketext(
-		'Closing date of this assignment extended by 24 hours to [_1].',
+		'Close date of this assignment extended by 24 hours to [_1].',
 		$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
 	);
 }

lib/WeBWorK/AchievementItems/ExtendDueDateGW.pm

@@ -77,7 +77,7 @@ sub use_item ($self, $set, $records, $c) {
 	#	$db->putSetVersion($set);
 	#}
 
-	return $c->maketext('Close date of this test change to [_1].',
+	return $c->maketext('Close date of this test extended by 24 hours to [_1].',
 		$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat}));
 }
 

lib/WeBWorK/AchievementItems/ExtendReducedDate.pm

@@ -76,7 +76,7 @@ sub use_item ($self, $set, $records, $c) {
 	$db->putUserSet($userSet);
 
 	return $c->maketext(
-		'Reduced scoring date of this assignment exted by 24 hours to [_1].',
+		'Reduced scoring date of this assignment extended by 24 hours to [_1].',
 		$c->formatDateTime($self->{new_date}, $c->ce->{studentDateDisplayFormat})
 	);
 }

lib/WeBWorK/AchievementItems/HalfCreditProb.pm

@@ -42,7 +42,7 @@ sub print_form ($self, $set, $records, $c) {
 	return WeBWorK::AchievementItems::form_popup_menu_row(
 		$c,
 		id         => 'half_cred_problem_id',
-		label_text => $c->maketext('Problem number to give half credit'),
+		label_text => $c->maketext('Problem number to increase grade by 50%'),
 		first_item => $c->maketext('Choose problem to increase grade by 50%.'),
 		values     => [
 			map { [

lib/WeBWorK/AchievementItems/NoReducedCred.pm

@@ -54,7 +54,7 @@ sub print_form ($self, $set, $records, $c) {
 	return $c->tag(
 		'p',
 		$c->maketext(
-			'Remove the reduced scoring pentaly from this assignment. Problems submitted before '
+			'Remove the reduced scoring penalty from this assignment. Problems submitted before '
 				. 'the close date on [_1] will earn full credit. Any problems that have already been '
 				. 'penalized will have to be resubmitted for full credit.',
 			$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
@@ -74,7 +74,7 @@ sub use_item ($self, $set, $records, $c) {
 	$userSet->reduced_scoring_date($set->due_date);
 	$db->putUserSet($userSet);
 
-	return $c->maketext('Reduced scoring pentaly removed.');
+	return $c->maketext('Reduced scoring penalty removed.');
 }
 
 1;

lib/WeBWorK/AchievementItems/ReducedCred.pm

@@ -56,7 +56,7 @@ sub print_form ($self, $set, $records, $c) {
 		'p',
 		$c->maketext(
 			'Extend the close date of this assignment to [_1] (an additional 24 hours).  Any submissions during '
-				. 'this additional time will be reducend and are worth [_2]% of their full value. [_3]',
+				. 'this additional time will be reduced and are worth [_2]% of their full value. [_3]',
 			$c->formatDateTime($set->due_date + ONE_DAY, $ce->{studentDateDisplayFormat}),
 			100 * $ce->{pg}{ansEvalDefaults}{reducedScoringValue},
 			$randomization_statement
@@ -103,8 +103,10 @@ sub use_item ($self, $set, $records, $c) {
 	}
 	$db->putUserSet($userSet);
 
-	return $c->maketext('Close date changed by 24 hours to [_1].',
-		$c->formatDateTime($set->due_date, $ce->{studentDateDisplayFormat}));
+	return $c->maketext(
+		'Close date of this assignment extended by 24 hours to [_1].',
+		$c->formatDateTime($set->due_date, $ce->{studentDateDisplayFormat})
+	);
 }
 
 1;

lib/WeBWorK/AchievementItems/ResurrectGW.pm

@@ -64,7 +64,7 @@ sub use_item ($self, $set, $records, $c) {
 	$userSet->answer_date($set->answer_date);
 	$db->putUserSet($userSet);
 
-	return $c->maketext('Close date of this test extended 24 hours to [_1].',
+	return $c->maketext('Close date of this test extended by 24 hours to [_1].',
 		$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat}));
 }
 

lib/WeBWorK/AchievementItems/ResurrectHW.pm

@@ -70,7 +70,7 @@ sub use_item ($self, $set, $records, $c) {
 	$db->putUserSet($userSet);
 
 	return $c->maketext(
-		'Closing date of this assignment extended by 24 hours to [_1].',
+		'Close date of this assignment extended by 24 hours to [_1].',
 		$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
 	);
 }

lib/WeBWorK/AchievementItems/SuperExtendDueDate.pm

@@ -83,7 +83,7 @@ sub use_item ($self, $set, $records, $c) {
 	$db->putUserSet($userSet);
 
 	return $c->maketext(
-		'Closing date of this assignment extended by 48 hours too [_1].',
+		'Close date of this assignment extended by 48 hours to [_1].',
 		$c->formatDateTime($set->due_date, $c->ce->{studentDateDisplayFormat})
 	);
 }