Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPEV: Expansion of the Vulnerability Field #15

Closed
puerco opened this issue Jul 10, 2023 · 7 comments
Closed

OPEV: Expansion of the Vulnerability Field #15

puerco opened this issue Jul 10, 2023 · 7 comments

Comments

@puerco
Copy link
Member

puerco commented Jul 10, 2023

OPEV # 0015: Expansion of the Vulnerability Field

πŸ–ŠοΈ Enhancement Overview

During the development of the initial implementations, there have been issues raised about the need to expand the vulnerability field. While this OPEV only addresses the need to expand the vulnerability field 1) become an object and to
2) to express more names or aliases of a vulnerability, members of the community have pointed to other cases where the vulnerability entry needs to be expanded from an identifier string to a full struct.

πŸ§‘β€πŸ’» Enhancement Proposal Authors

πŸ‘©β€πŸ”§ Sponsoring Maintainers

(not required)

πŸ“‹ OpenVEX Projects

  • openvex/spec
  • openvex/go-vex
  • openvex/vexctl

πŸ“ Specs and Documents

Pull Request open: #17

❓ Enhancement Questions

Does this enhancement propose a change to the OpenVEX project's governance
structure?

NO

Does this enhancement propose a breaking change with the upstream VEX design
established by the VEX Working Group?

NO

πŸ’¬ Discussion Start Date:

OPEVs shall be discussed for no longer than 30 days after which the vote tally
will be computed and the proposal will either merge or be rejected.

Start Date: 2023-07-09

πŸ—³οΈ Voting Results

Final Enhancement Vote Tally:

Final Enhancement Vote Tally:

πŸ‘ : 3 Votes @lumjjb @wagoodman @puerco (implicit) | non binding: @SecurityCRob

πŸ‘Ž : 0 Votes


ℹ️ Voting Instructions:

To vote for this enhancement, maintainers should add a comment with a πŸ‘ emoji
to show support or πŸ‘Ž to reject the enhancement. After voting is over (usually
after 30 days), votes will be computed by the project's mantainers and
registered in this issue. Refer to GOVERNANCE.md for details
on how many votes are required to approve and when voting ends.

@lumjjb
Copy link
Contributor

lumjjb commented Jul 20, 2023

I think adding a referencable object with the actual contents as optional may lead to failure to resolve some of these details at consumption time (unable to get object). Although I see the value of using the reference, i worry about the reliability to rely on it solely as a pattern for common use. As of the current state of maturity of cross-referencing objects across standards and the adoption of json LD by these standards, i would be more comfortable if it was not optional to include the vulnerability identifiers within the struct.

i.e. the example here wouldn't be possible without the additional resolved information from the original format.

This may just be a rewording and a recommendation instead of a change in the struct definition

@SecurityCRob
Copy link

While not a voting member, I agree with and endorse this update. I think this helps set us up for success as we start to see openvex used more broadly.

@puerco
Copy link
Member Author

puerco commented Jul 22, 2023

@lumjjb so, do you think we should make name required? We can mark it in the spec. In its minimal form, the vulnerability field would be:

"vulnerability": {
   "name": "CVE-2019-17571"
}

@lumjjb
Copy link
Contributor

lumjjb commented Jul 31, 2023

yep - that works!. sorry for the late response, was out sick.

@wagoodman
Copy link

πŸ‘

@puerco
Copy link
Member Author

puerco commented Aug 7, 2023

@lumjjb 76ef832 adds language to specify name as required πŸ‘

@puerco
Copy link
Member Author

puerco commented Aug 8, 2023

Proposal approved and enhancement document has merged πŸŽ‰ https://github.com/openvex/community/blob/main/enhancements/opev-0015.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants