Style fixes from Sonar CI

Author: jentfoo

sdk/src/main/java/io/opentdf/platform/sdk/Manifest.java

@@ -483,8 +483,6 @@ protected static Manifest readManifest(Reader reader) {
             throw new IllegalArgumentException("Manifest with null encryptionInformation");
         } else if (result.encryptionInformation.integrityInformation == null) {
             throw new IllegalArgumentException("Manifest with null integrityInformation");
-        } else if (result.encryptionInformation.integrityInformation.segments == null) {
-            throw new IllegalArgumentException("Manifest with invalid integrityInformation");
         } else if (result.encryptionInformation.integrityInformation.rootSignature == null) {
             throw new IllegalArgumentException("Manifest with null rootSignature");
         } else if (result.encryptionInformation.integrityInformation.rootSignature.algorithm == null

sdk/src/main/java/io/opentdf/platform/sdk/TDF.java

@@ -361,9 +361,7 @@ public void readPayload(OutputStream outputStream) throws TDFReadFailed,
             for (Manifest.Segment segment : manifest.encryptionInformation.integrityInformation.segments) {
                 if (segment.encryptedSegmentSize > Config.MAX_SEGMENT_SIZE) {
                     throw new IllegalStateException("Segment size " + segment.encryptedSegmentSize + " exceeded limit " + Config.MAX_SEGMENT_SIZE);
-                }/* else if (segment.encryptedSegmentSize < Config.MIN_SEGMENT_SIZE) {
-                    throw new IllegalStateException("Segment size " + segment.encryptedSegmentSize + " is under minimum " + Config.MIN_SEGMENT_SIZE);
-                }*/ // Commented out due to tests needing small segment sizes with existing payloads
+                } // MIN_SEGMENT_SIZE NOT validated out due to tests needing small segment sizes with existing payloads
 
                 byte[] readBuf = new byte[(int) segment.encryptedSegmentSize];
                 int bytesRead = tdfReader.readPayloadBytes(readBuf);

sdk/src/test/java/io/opentdf/platform/sdk/ConfigTest.java

@@ -54,7 +54,7 @@ void withSegmentSize_shouldSetSegmentSize() {
     @Test
     void withSegmentSize_shouldIgnoreSegmentSize() {
         try {
-            Config.newTDFConfig(Config.withSegmentSize(1024));
+            Config.withSegmentSize(1024);
             fail("Expected exception");
         } catch (IllegalArgumentException e) {
             // expected

sdk/src/test/java/io/opentdf/platform/sdk/Fuzzing.java

@@ -18,27 +18,27 @@
 import io.opentdf.platform.sdk.TDF.Reader;
 
 public class Fuzzing {
-    private static final String testDuration = "600s";
-    private static final OutputStream ignoreOutputStream = new OutputStream() {
+    private static final String TEST_DURATION = "600s";
+    private static final OutputStream IGNORE_OUTPUT_STREAM = new OutputStream() {
         @Override
         public void write(int b) {
             // ignored
         }
 
         @Override
-        public void write(byte b[], int off, int len) {
+        public void write(byte[] b, int off, int len) {
             // ignored
         }
     };
 
-    @FuzzTest(maxDuration=testDuration)
+    @FuzzTest(maxDuration=TEST_DURATION)
     public void fuzzNanoTDF(FuzzedDataProvider data) throws IOException {
         byte[] fuzzBytes = data.consumeRemainingAsBytes();
         NanoTDF nanoTDF = new NanoTDF();
-        nanoTDF.readNanoTDF(ByteBuffer.wrap(fuzzBytes), ignoreOutputStream, NanoTDFTest.kas);
+        nanoTDF.readNanoTDF(ByteBuffer.wrap(fuzzBytes), IGNORE_OUTPUT_STREAM, NanoTDFTest.kas);
     }
 
-    @FuzzTest(maxDuration=testDuration)
+    @FuzzTest(maxDuration=TEST_DURATION)
     public void fuzzTDF(FuzzedDataProvider data) throws FailedToCreateGMAC, NoSuchAlgorithmException, IOException, JOSEException, ParseException, DecoderException {
         byte[] fuzzBytes = data.consumeRemainingAsBytes();
         byte[] key = new byte[32];      // use consistent zero key for performance and so fuzz can relate to seed
@@ -51,13 +51,13 @@ public void fuzzTDF(FuzzedDataProvider data) throws FailedToCreateGMAC, NoSuchAl
         try {
             Reader reader = tdf.loadTDF(new SeekableInMemoryByteChannel(fuzzBytes), TDFTest.kas, readerConfig);
 
-            reader.readPayload(ignoreOutputStream);
+            reader.readPayload(IGNORE_OUTPUT_STREAM);
         } catch (SDKException | InvalidZipException | JsonParseException | IOException | IllegalArgumentException e) {
             // expected failure cases
         }
     }
 
-    @FuzzTest(maxDuration=testDuration)
+    @FuzzTest(maxDuration=TEST_DURATION)
     public void fuzzZipRead(FuzzedDataProvider data) {
         byte[] fuzzBytes = data.consumeRemainingAsBytes();
         try {

sdk/src/test/java/io/opentdf/platform/sdk/TDFTest.java

@@ -1,11 +1,6 @@
 package io.opentdf.platform.sdk;
 
-import com.google.common.util.concurrent.ListenableFuture;
-
 import com.nimbusds.jose.JOSEException;
-import io.opentdf.platform.policy.attributes.GetAttributeValuesByFqnsRequest;
-import io.opentdf.platform.policy.attributes.GetAttributeValuesByFqnsResponse;
-import io.opentdf.platform.policy.attributes.AttributesServiceGrpc;
 import io.opentdf.platform.sdk.Config.KASInfo;
 import io.opentdf.platform.sdk.TDF.Reader;
 import io.opentdf.platform.sdk.nanotdf.NanoTDFType;

sdk/src/test/java/io/opentdf/platform/sdk/ZipReaderTest.java

@@ -1,5 +1,4 @@
 package io.opentdf.platform.sdk;
-import com.google.gson.Gson;
 import com.google.gson.GsonBuilder;
 
 import io.opentdf.platform.sdk.Manifest.ManifestDeserializer;
@@ -12,13 +11,10 @@
 
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
-import java.io.File;
 import java.io.IOException;
 import java.io.RandomAccessFile;
 import java.nio.channels.SeekableByteChannel;
 import java.nio.charset.StandardCharsets;
-import java.nio.file.Files;
-import java.nio.file.Path;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Random;