Skip to content

Commit 60364b3

Browse files
committed
Revert "Adds tests for resize server for swap"
The test_flavor_swap_1024_to_0() test seems to be failing to assert zero swap devs after the resize very frequently. This has been merged for less than 24 hours so I'm proposing this revert to avoid blocking the gate. This reverts commit a20f89d. Change-Id: I4184abbc85368affe557005628f6385c224ffe73
1 parent b1e1680 commit 60364b3

File tree

3 files changed

+0
-110
lines changed

3 files changed

+0
-110
lines changed

tempest/api/compute/admin/test_create_server.py

-94
Original file line numberDiff line numberDiff line change
@@ -136,97 +136,3 @@ def create_flavor_with_ephemeral(ephem_disk):
136136
servers_client=self.client)
137137
disks_num_eph = len(linux_client.get_disks().split('\n'))
138138
self.assertEqual(disks_num + 1, disks_num_eph)
139-
140-
141-
class ServersWithFlavorSwapResizeTest(base.BaseV2ComputeAdminTest):
142-
"""Test resizing flavor swap size"""
143-
144-
@classmethod
145-
def setup_credentials(cls):
146-
cls.prepare_instance_network()
147-
super(ServersWithFlavorSwapResizeTest, cls).setup_credentials()
148-
149-
@classmethod
150-
def setup_clients(cls):
151-
super(ServersWithFlavorSwapResizeTest, cls).setup_clients()
152-
cls.client = cls.servers_client
153-
154-
def _create_server_with_swap(self, swap=0):
155-
admin_pass = self.image_ssh_password
156-
validation_resources = self.get_test_validation_resources(
157-
self.os_primary)
158-
159-
flavor_id = self.create_flavor(
160-
ram=1024, vcpus=1, disk=1, swap=swap)['id']
161-
162-
server = self.create_test_server(
163-
validatable=True,
164-
validation_resources=validation_resources,
165-
wait_until='ACTIVE',
166-
adminPass=admin_pass,
167-
flavor=flavor_id)
168-
169-
self.addCleanup(waiters.wait_for_server_termination,
170-
self.servers_client, server['id'])
171-
self.addCleanup(test_utils.call_and_ignore_notfound_exc,
172-
self.servers_client.delete_server,
173-
server['id'])
174-
175-
server = self.client.show_server(server['id'])['server']
176-
177-
ssh_client = self.get_ssh_client(
178-
server, validation_resources, admin_pass)
179-
return server, ssh_client
180-
181-
def _resize_server_with_new_swap(self, server, swap=0):
182-
flavor_id = self.create_flavor(
183-
ram=1024, vcpus=1, disk=1, swap=swap)['id']
184-
self.resize_server(server['id'], flavor_id)
185-
186-
@decorators.idempotent_id('b2c7bcfc-bb5b-4e22-b517-c7f686b80211')
187-
def test_flavor_swap_0_to_1024(self):
188-
server, ssh_client = self._create_server_with_swap(swap=0)
189-
swap_devs = len(ssh_client.get_swap_devs())
190-
191-
self.assertEqual(swap_devs, 0)
192-
193-
self._resize_server_with_new_swap(server, swap=1024)
194-
swap_devs = len(ssh_client.get_swap_devs())
195-
196-
self.assertEqual(swap_devs, 1)
197-
198-
self.reboot_server(server['id'], 'hard')
199-
swap_devs = len(ssh_client.get_swap_devs())
200-
self.assertEqual(swap_devs, 1)
201-
202-
@decorators.idempotent_id('b2c7bcfc-bb5b-4e22-b517-c7f686b80212')
203-
def test_flavor_swap_2048_to_1024(self):
204-
server, ssh_client = self._create_server_with_swap(swap=2048)
205-
swap_devs = len(ssh_client.get_swap_devs())
206-
207-
self.assertEqual(swap_devs, 1)
208-
209-
self._resize_server_with_new_swap(server, swap=1024)
210-
swap_devs = len(ssh_client.get_swap_devs())
211-
212-
self.assertEqual(swap_devs, 1)
213-
214-
self.reboot_server(server['id'], 'hard')
215-
swap_devs = len(ssh_client.get_swap_devs())
216-
self.assertEqual(swap_devs, 1)
217-
218-
@decorators.idempotent_id('b2c7bcfc-bb5b-4e22-b517-c7f686b80213')
219-
def test_flavor_swap_1024_to_0(self):
220-
server, ssh_client = self._create_server_with_swap(swap=1024)
221-
swap_devs = len(ssh_client.get_swap_devs())
222-
223-
self.assertEqual(swap_devs, 1)
224-
225-
self._resize_server_with_new_swap(server, swap=0)
226-
swap_devs = len(ssh_client.get_swap_devs())
227-
228-
self.assertEqual(swap_devs, 0)
229-
230-
self.reboot_server(server['id'], 'hard')
231-
swap_devs = len(ssh_client.get_swap_devs())
232-
self.assertEqual(swap_devs, 0)

tempest/api/compute/base.py

-10
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
from oslo_log import log as logging
1919

2020
from tempest.common import compute
21-
from tempest.common.utils.linux import remote_client
2221
from tempest.common import waiters
2322
from tempest import config
2423
from tempest import exceptions
@@ -733,12 +732,3 @@ def get_host_other_than(self, server_id):
733732
for target_host in hosts:
734733
if source_host != target_host:
735734
return target_host
736-
737-
def get_ssh_client(self, server, validation_resources, admin_pass):
738-
return remote_client.RemoteClient(
739-
self.get_server_ip(server, validation_resources),
740-
self.ssh_user,
741-
admin_pass,
742-
validation_resources['keypair']['private_key'],
743-
server=server,
744-
servers_client=self.client)

tempest/common/utils/linux/remote_client.py

-6
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,3 @@ def tcp_check(self, host, **kwargs):
244244
"""Wrapper for tcp connectivity checks."""
245245
kwargs.pop('nic', None)
246246
return self.nc_host(host, **kwargs)
247-
248-
def get_swap_devs(self):
249-
cmd = 'blkid'
250-
data = self.exec_command(cmd)
251-
devs = [dev for dev in data.splitlines() if 'TYPE="swap"' in dev]
252-
return devs

0 commit comments

Comments
 (0)