fix(jira): address remaining CodeRabbit nitpicks

- Remove dead lower() helper from score_candidates.py
- Simplify redundant elif guard in component check
- Add defensive .lower() in find_lower for case-insensitive matching
- Guard against empty target_release in build_jql.py
- Add from __future__ import annotations to all scripts for Python 3.9+

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Enrique Llorente Pastora <ellorent@redhat.com>

Author: qinqon

plugins/jira/skills/candidates-from-pr/scripts/build_jql.py

@@ -9,6 +9,8 @@
     derive_filters.py ... | build_jql.py [--project OCPBUGS]
 """
 
+from __future__ import annotations
+
 import argparse
 import json
 import sys
@@ -32,7 +34,7 @@ def main() -> None:
         parts.append(f"component in ({comps})")
 
     target_release = filters.get("target_release")
-    if target_release:
+    if target_release and target_release.strip():
         parts.append(
             f'("Target Version" = {quote(target_release)} '
             f"OR fixVersion = {quote(target_release)})"

plugins/jira/skills/candidates-from-pr/scripts/derive_filters.py

@@ -21,6 +21,8 @@
     }
 """
 
+from __future__ import annotations
+
 import argparse
 import json
 import re

plugins/jira/skills/candidates-from-pr/scripts/extract_jira_keys.py

@@ -15,6 +15,8 @@
 validate via mcp__atlassian__jira_get_issue.
 """
 
+from __future__ import annotations
+
 import argparse
 import json
 import re

plugins/jira/skills/candidates-from-pr/scripts/extract_signals.py

@@ -19,6 +19,8 @@
     }
 """
 
+from __future__ import annotations
+
 import json
 import re
 import sys

plugins/jira/skills/candidates-from-pr/scripts/fetch_pr.py

@@ -14,6 +14,8 @@
     diff (capped), diff_truncated (bool), diff_total_lines
 """
 
+from __future__ import annotations
+
 import argparse
 import json
 import re

plugins/jira/skills/candidates-from-pr/scripts/render_report.py

@@ -19,6 +19,8 @@
 list of matched signal values.
 """
 
+from __future__ import annotations
+
 import argparse
 import json
 import sys

plugins/jira/skills/candidates-from-pr/scripts/score_candidates.py

@@ -36,6 +36,8 @@
 sentence rationale.
 """
 
+from __future__ import annotations
+
 import argparse
 import json
 import sys
@@ -45,10 +47,6 @@
 DROP_STATUSES = {"Verified", "Closed"}
 
 
-def lower(value: str | None) -> str:
-    return (value or "").lower()
-
-
 def load(path: str) -> object:
     with open(path) as f:
         return json.load(f)
@@ -65,7 +63,7 @@ def find_in_text(needles: list[str], text: str) -> list[str]:
 def find_lower(needles: list[str], text_lower: str) -> list[str]:
     if not needles or not text_lower:
         return []
-    return [n for n in needles if n and n in text_lower]
+    return [n for n in needles if n and n.lower() in text_lower]
 
 
 def score_one(
@@ -120,7 +118,7 @@ def score_one(
                 "value": next(iter(cand_components & derived_components)),
             }
         )
-    elif component_filter_used and not (cand_components & derived_components):
+    elif component_filter_used:
         # JQL should have prevented this; guard anyway.
         score = 0
         return score, matched