From 66424759220ee3f1b75c8f8d7ea6f4c6bffec261 Mon Sep 17 00:00:00 2001 From: Simeon Widdis Date: Wed, 29 Jan 2025 14:30:34 -0800 Subject: [PATCH] Reuse contextStartIndex variable Signed-off-by: Simeon Widdis --- .../sql/common/antlr/SyntaxAnalysisErrorListener.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/src/main/java/org/opensearch/sql/common/antlr/SyntaxAnalysisErrorListener.java b/common/src/main/java/org/opensearch/sql/common/antlr/SyntaxAnalysisErrorListener.java index 7e435a4344..a47f6a98b6 100644 --- a/common/src/main/java/org/opensearch/sql/common/antlr/SyntaxAnalysisErrorListener.java +++ b/common/src/main/java/org/opensearch/sql/common/antlr/SyntaxAnalysisErrorListener.java @@ -48,11 +48,11 @@ private String getOffendingText(Token offendingToken) { } private String truncateQueryAtOffendingToken(String query, Token offendingToken) { - int contextStart = offendingToken.getStartIndex() - CONTEXT_TRUNCATION_THRESHOLD; - if (offendingToken.getStartIndex() - CONTEXT_TRUNCATION_THRESHOLD <= 3) { + int contextStartIndex = offendingToken.getStartIndex() - CONTEXT_TRUNCATION_THRESHOLD; + if (contextStartIndex < 3) { // The ellipses won't save us anything below the first 4 characters return query.substring(0, offendingToken.getStopIndex() + 1); } - return "..." + query.substring(contextStart, offendingToken.getStopIndex() + 1); + return "..." + query.substring(contextStartIndex, offendingToken.getStopIndex() + 1); } private String getDetails(Recognizer recognizer, String msg, RecognitionException e) {