From 5c42357b75ea3e3c2ce32d00351a3321a92c674e Mon Sep 17 00:00:00 2001 From: David Venable Date: Wed, 4 Sep 2024 16:25:53 -0500 Subject: [PATCH 1/2] Update testing GitHub workflows to use pull_request instead of pull_request_target. Using pull_request_target runs against the target branch, but this doesn't let us test the changes coming in as we'd like. Signed-off-by: David Venable --- .github/workflows/data-prepper-aws-secrets-e2e-tests.yml | 2 +- .github/workflows/kafka-plugin-integration-tests.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml b/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml index 26247886f8..01df80ccba 100644 --- a/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml +++ b/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml @@ -5,7 +5,7 @@ name: Data Prepper AWS secrets End-to-end test with Gradle on: push: branches: [ main ] - pull_request_target: + pull_request: types: [ opened, synchronize, reopened ] workflow_dispatch: # permission can be added at job level or workflow level diff --git a/.github/workflows/kafka-plugin-integration-tests.yml b/.github/workflows/kafka-plugin-integration-tests.yml index 72d6645d53..f5a6b5edce 100644 --- a/.github/workflows/kafka-plugin-integration-tests.yml +++ b/.github/workflows/kafka-plugin-integration-tests.yml @@ -8,7 +8,7 @@ on: paths: - 'data-prepper-plugins/kafka-plugins/**' - '*gradle*' - pull_request_target: + pull_request: types: [ opened, synchronize, reopened ] paths: - 'data-prepper-plugins/kafka-plugins/**' From bcc2ed674ec92c05308c0a00ece785790744562b Mon Sep 17 00:00:00 2001 From: David Venable Date: Wed, 4 Sep 2024 16:45:23 -0500 Subject: [PATCH 2/2] We need to use pull_request_target for now on the AWS Secrets tests. Signed-off-by: David Venable --- .github/workflows/data-prepper-aws-secrets-e2e-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml b/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml index 01df80ccba..26247886f8 100644 --- a/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml +++ b/.github/workflows/data-prepper-aws-secrets-e2e-tests.yml @@ -5,7 +5,7 @@ name: Data Prepper AWS secrets End-to-end test with Gradle on: push: branches: [ main ] - pull_request: + pull_request_target: types: [ opened, synchronize, reopened ] workflow_dispatch: # permission can be added at job level or workflow level