Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Do not report documentVersionConflictErrors in documentErrors metric in the OpenSearch sink #5376

Open
graytaylor0 opened this issue Jan 30, 2025 · 1 comment
Open

[BUG] Do not report documentVersionConflictErrors in documentErrors metric in the OpenSearch sink #5376

graytaylor0 opened this issue Jan 30, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@graytaylor0
Copy link
Member

Describe the bug
The documentVersionConflictErrrors in the OpenSearch sink are not sent to DLQ and are not a true documentError since it means the latest document is in OpenSearch already. Due to this, it should not be included in the documentErrors metric, as this is a confusing user experience.

Expected behavior
Do not include documentVersionConflictError in the overall documentErrors metric
@graytaylor0 graytaylor0 added bug Something isn't working untriaged labels Jan 30, 2025
@graytaylor0 graytaylor0 changed the title [BUG] [BUG] Do not report documentVersionConflictErrors in documentErrors metric in the OpenSearch sink Jan 30, 2025
@dlvenable
Copy link
Member

Something to consider: What if the version conflict is a true error? Say if the version was generated internally and the document actually does conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Data Prepper Tracking Board
Status: Unplanned
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlvenable @graytaylor0