Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an additional manual circuit breaker #4145

Open
dlvenable opened this issue Feb 17, 2024 · 0 comments
Open

Support an additional manual circuit breaker #4145

dlvenable opened this issue Feb 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dlvenable
Copy link
Member

Is your feature request related to a problem? Please describe.

Initially, I'd like to be able to test the circuit breaker behavior using manual controls. Additionally, there may be value in stopping a pipeline temporarily.

Describe the solution you'd like

Provide an HTTP endpoint for opening and closing a circuit breaker.

First, it should be enabled in data-prepper-config.yaml:

circuit_breakers:
  http_forced:
    enabled: true

Then to open the circuit breaker:

curl -X POST http://localhost:4900/circuit_breaker/forced

Then to close the circuit breaker:

curl -X DELETE http://localhost:4900/circuit_breaker/forced

Describe alternatives you've considered (Optional)

Provide a full override of all circuit breakers. But, this could result in running out of memory.

I'd like to see if there is a better name. Right now, I'm calling it "forced," but I think we could do better.

Another idea would be to set the circuit breaker with a timeout. I tend to think this might be a completely different circuit breaker so that the forced one is not interfered with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant