Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maximum back-off delay a configuration option #3744

Open
rhys-evans opened this issue Dec 1, 2023 · 1 comment
Open

Make maximum back-off delay a configuration option #3744

rhys-evans opened this issue Dec 1, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rhys-evans
Copy link

Is your feature request related to a problem? Please describe.
At present the maximum back-off delay (for SQS, not sure if others) is hard coded, we would like to be able to set that to a user defined value

Describe the solution you'd like
A configuration option to set the maximum back-off delay

Describe alternatives you've considered (Optional)

Additional context
Sourced from #3726

@saketh-pallempati
Copy link

saketh-pallempati commented Feb 4, 2025

Hi everyone,
I just got across a talk on open search by @dlvenable and was really inspired to make a contribution.
So I would like to make small contribution on this issue.

My approach will be as follows:

Update S3SourceConfig Class:

Add a new field for MAXIMUM_DELAY.
Provide a getter method for the new field.

Modify SqsService Class:

Remove the hard-coded MAXIMUM_DELAY.
Use the new configuration parameter s3SourceConfig.getMaximumBackoffDelay() to set the maximum back-off delay dynamically.

Update Configuration File:

Add a new parameter maximum_backoff_delay to the configuration file to allow users to specify the maximum back-off delay.
This will make the maximum back-off delay user-configurable, enhancing the flexibility and usability of the SqsService class.

Looking forward to your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants