Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename artifact produced by the build to include -min #1094

Closed
dblock opened this issue Aug 15, 2021 · 2 comments
Closed

Rename artifact produced by the build to include -min #1094

dblock opened this issue Aug 15, 2021 · 2 comments
Assignees
@xuezhou25
Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers

Comments

@dblock
Copy link
Member

dblock commented Aug 15, 2021

Is your feature request related to a problem? Please describe.

Coming from opensearch-project/opensearch-build#212, the output of ./gradlew :distribution:archives:linux-tar:assemble produces a file called opensearch-1.1.0-SNAPSHOT-linux-x64.tar.gz. Then we rename it to -min, ie. opensearch-min-1.1.0-SNAPSHOT-linux-x64.tar.gz.

Describe the solution you'd like

Rename output to always include -min.
@dblock dblock added the enhancement Enhancement or improvement to existing feature or request label Aug 15, 2021
This was referenced Aug 15, 2021
Closed
Merged
@mch2 mch2 mentioned this issue Aug 23, 2021
Merged
@mch2
Copy link
Member

mch2 commented Aug 26, 2021 •
edited
Loading

This logic- will also need to be removed from our CI scripts so CI does not produce opensearch-min-min.

@anasalkouz anasalkouz self-assigned this Aug 27, 2021
@xuezhou25
Copy link
Contributor

🙌

@anasalkouz anasalkouz assigned xuezhou25 and unassigned anasalkouz Sep 10, 2021
This was referenced Sep 16, 2021
Merged
Merged
Merged
@tlfeng tlfeng mentioned this issue Sep 23, 2021
Merged
1 task
@dblock dblock closed this as completed Sep 23, 2021
@dblock dblock mentioned this issue Sep 23, 2021
Closed
xuezhou25 added a commit to xuezhou25/OpenSearch that referenced this issue Sep 24, 2021
@xuezhou25
fix gradle check fail due to renameing -min in opensearch-project#1094
2ddf050 
Signed-off-by: Xue Zhou <[email protected]>
@xuezhou25 xuezhou25 mentioned this issue Sep 24, 2021
Merged
5 tasks
nknize pushed a commit that referenced this issue Sep 24, 2021
@xuezhou25
fix gradle check fail due to renameing -min in #1094 (#1289)
82d1d0e 
Signed-off-by: Xue Zhou <[email protected]>
xuezhou25 added a commit to xuezhou25/OpenSearch that referenced this issue Sep 24, 2021
@xuezhou25
fix gradle check fail due to renameing -min in opensearch-project#1094 (
6c1fd7d 
opensearch-project#1289)

Signed-off-by: Xue Zhou <[email protected]>
dblock pushed a commit that referenced this issue Sep 24, 2021
@xuezhou25
fix gradle check fail due to renameing -min in #1094 (#1289) (#1291)
dbc3066 
Signed-off-by: Xue Zhou <[email protected]>
nknize pushed a commit that referenced this issue Sep 25, 2021
@xuezhou25 @nknize
fix gradle check fail due to renameing -min in #1094 (#1289) (#1291)
2183c7c 
Signed-off-by: Xue Zhou <[email protected]>
@bbarani bbarani mentioned this issue Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuezhou25 xuezhou25

Labels
enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dblock @mch2 @anasalkouz @xuezhou25