Skip to content

Commit d400607

Browse files
committed
Fix failing tests
The `UpdateMysqlDriverArtifactIdTest` and `UpdateGradleTest` tests were failing because they called `Environment.Builder#scanRuntimeClasspath()` with a too specific package name. The recipe was found, but in its list it referred to other recipes which were not found and as a result the tests failed.
1 parent bbea04a commit d400607

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/testWithSpringBoot_2_7/java/org/openrewrite/gradle/spring/UpdateGradleTest.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class UpdateGradleTest implements RewriteTest {
3333
@Override
3434
public void defaults(RecipeSpec spec) {
3535
spec.recipe(Environment.builder()
36-
.scanRuntimeClasspath("org.openrewrite.java.spring.boot2")
36+
.scanRuntimeClasspath()
3737
.build()
3838
.activateRecipes("org.openrewrite.java.spring.boot2.UpgradeSpringBoot_2_7"))
3939
.beforeRecipe(withToolingApi())
@@ -44,6 +44,7 @@ public void defaults(RecipeSpec spec) {
4444
void upgradeGradleWrapperAndPlugins() {
4545
rewriteRun(
4646
buildGradle(
47+
//language=gradle
4748
"""
4849
plugins {
4950
id "java"
@@ -59,6 +60,7 @@ void upgradeGradleWrapperAndPlugins() {
5960
implementation "org.springframework.boot:spring-boot-starter-web"
6061
}
6162
""",
63+
//language=gradle
6264
"""
6365
plugins {
6466
id "java"
@@ -76,13 +78,15 @@ void upgradeGradleWrapperAndPlugins() {
7678
"""
7779
),
7880
properties(
81+
//language=properties
7982
"""
8083
distributionBase=GRADLE_USER_HOME
8184
distributionPath=wrapper/dists
8285
distributionUrl=https\\://services.gradle.org/distributions/gradle-6.7-bin.zip
8386
zipStoreBase=GRADLE_USER_HOME
8487
zipStorePath=wrapper/dists
8588
""",
89+
//language=properties
8690
"""
8791
distributionBase=GRADLE_USER_HOME
8892
distributionPath=wrapper/dists
@@ -123,6 +127,7 @@ void upgradeGradleWrapperAndPlugins() {
123127
void dontAddSpringDependencyManagementWhenUsingGradlePlatform() {
124128
rewriteRun(
125129
buildGradle(
130+
//language=gradle
126131
"""
127132
plugins {
128133
id "java"
@@ -138,6 +143,7 @@ implementation platform("org.springframework.boot:spring-boot-dependencies:2.6.1
138143
implementation "org.springframework.boot:spring-boot-starter-web"
139144
}
140145
""",
146+
//language=gradle
141147
"""
142148
plugins {
143149
id "java"
@@ -155,13 +161,15 @@ implementation platform("org.springframework.boot:spring-boot-dependencies:2.7.1
155161
"""
156162
),
157163
properties(
164+
//language=properties
158165
"""
159166
distributionBase=GRADLE_USER_HOME
160167
distributionPath=wrapper/dists
161168
distributionUrl=https\\://services.gradle.org/distributions/gradle-6.7-bin.zip
162169
zipStoreBase=GRADLE_USER_HOME
163170
zipStorePath=wrapper/dists
164171
""",
172+
//language=properties
165173
"""
166174
distributionBase=GRADLE_USER_HOME
167175
distributionPath=wrapper/dists

src/testWithSpringBoot_2_7/java/org/openrewrite/java/spring/boot2/UpdateMysqlDriverArtifactIdTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class UpdateMysqlDriverArtifactIdTest implements RewriteTest {
3737
@Override
3838
public void defaults(RecipeSpec spec) {
3939
spec.recipe(Environment.builder()
40-
.scanRuntimeClasspath("org.openrewrite.java.spring.boot2")
40+
.scanRuntimeClasspath()
4141
.build()
4242
.activateRecipes("org.openrewrite.java.spring.boot2.UpgradeSpringBoot_2_7"));
4343
}

0 commit comments

Comments
 (0)