Webhook trigger /sync should receive response from HTTP action #1579
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the flow response handling for succeeded flows to support custom stop responses. When a flow completes successfully, it now checks for a custom stopResponse object and uses its status, body, and headers if present, otherwise returns a default success message.
Key Changes:
- Added conditional handling for custom stop responses in succeeded flows
- Changed default success response from
NO_CONTENTtoOKwith a message body
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| status: result.stopResponse?.status ?? StatusCodes.OK, | ||
| body: result.stopResponse?.body, | ||
| headers: result.stopResponse?.headers ?? {}, |
There was a problem hiding this comment.
The optional chaining on line 323 already checks if stopResponse exists, making the additional optional chaining (?.) on line 325 redundant. Since we're inside the if (result.stopResponse) block, you can safely access result.stopResponse.status directly.
| status: result.stopResponse?.status ?? StatusCodes.OK, | |
| body: result.stopResponse?.body, | |
| headers: result.stopResponse?.headers ?? {}, | |
| status: result.stopResponse.status ?? StatusCodes.OK, | |
| body: result.stopResponse.body, | |
| headers: result.stopResponse.headers ?? {}, |
| status: result.stopResponse?.status ?? StatusCodes.OK, | ||
| body: result.stopResponse?.body, | ||
| headers: result.stopResponse?.headers ?? {}, |
There was a problem hiding this comment.
Since we're inside the if (result.stopResponse) block, the optional chaining (?.) is unnecessary. You can access result.stopResponse.body directly.
| status: result.stopResponse?.status ?? StatusCodes.OK, | |
| body: result.stopResponse?.body, | |
| headers: result.stopResponse?.headers ?? {}, | |
| status: result.stopResponse.status ?? StatusCodes.OK, | |
| body: result.stopResponse.body, | |
| headers: result.stopResponse.headers ?? {}, |
| status: result.stopResponse?.status ?? StatusCodes.OK, | ||
| body: result.stopResponse?.body, | ||
| headers: result.stopResponse?.headers ?? {}, |
There was a problem hiding this comment.
Since we're inside the if (result.stopResponse) block, the optional chaining (?.) is redundant. You can access result.stopResponse.headers directly.
| status: result.stopResponse?.status ?? StatusCodes.OK, | |
| body: result.stopResponse?.body, | |
| headers: result.stopResponse?.headers ?? {}, | |
| status: result.stopResponse.status ?? StatusCodes.OK, | |
| body: result.stopResponse.body, | |
| headers: result.stopResponse.headers ?? {}, |
|
MarceloRGonc
changed the title
Part of OPS-2972.