Early error when Node middleware usage is detected (#978)

Author: vicb

.changeset/metal-items-watch.md

@@ -0,0 +1,5 @@
+---
+"@opennextjs/cloudflare": patch
+---
+
+error early when a node middleware is detected

packages/cloudflare/src/cli/build/build.ts

@@ -17,6 +17,7 @@ import { compileInit } from "./open-next/compile-init.js";
 import { compileSkewProtection } from "./open-next/compile-skew-protection.js";
 import { compileDurableObjects } from "./open-next/compileDurableObjects.js";
 import { createServerBundle } from "./open-next/createServerBundle.js";
+import { useNodeMiddleware } from "./utils/middleware.js";
 import { getVersion } from "./utils/version.js";
 
 /**
@@ -58,6 +59,12 @@ export async function build(
 		buildNextjsApp(options);
 	}
 
+	// Make sure no Node.js middleware is used
+	if (useNodeMiddleware(options)) {
+		logger.error("Node.js middleware is not currently supported. Consider switching to Edge Middleware.");
+		process.exit(1);
+	}
+
 	// Generate deployable bundle
 	printHeader("Generating bundle");
 

packages/cloudflare/src/cli/build/open-next/compileDurableObjects.ts

@@ -2,7 +2,7 @@ import { createRequire } from "node:module";
 import path from "node:path";
 
 import { loadBuildId, loadPrerenderManifest } from "@opennextjs/aws/adapters/config/util.js";
-import { type BuildOptions, esbuildSync, getPackagePath } from "@opennextjs/aws/build/helper.js";
+import { type BuildOptions, esbuildSync } from "@opennextjs/aws/build/helper.js";
 
 export function compileDurableObjects(buildOpts: BuildOptions) {
 	const _require = createRequire(import.meta.url);
@@ -12,16 +12,11 @@ export function compileDurableObjects(buildOpts: BuildOptions) {
 		_require.resolve("@opennextjs/cloudflare/durable-objects/bucket-cache-purge"),
 	];
 
-	const baseManifestPath = path.join(
-		buildOpts.outputDir,
-		"server-functions/default",
-		getPackagePath(buildOpts),
-		".next"
-	);
+	const buildOutputDotNextDir = path.join(buildOpts.appBuildOutputPath, ".next");
 
-	const prerenderManifest = loadPrerenderManifest(baseManifestPath);
+	const prerenderManifest = loadPrerenderManifest(buildOutputDotNextDir);
 	const previewModeId = prerenderManifest.preview.previewModeId;
-	const BUILD_ID = loadBuildId(baseManifestPath);
+	const BUILD_ID = loadBuildId(buildOutputDotNextDir);
 
 	return esbuildSync(
 		{

packages/cloudflare/src/cli/build/utils/middleware.ts

@@ -0,0 +1,26 @@
+import path from "node:path";
+
+import { loadFunctionsConfigManifest, loadMiddlewareManifest } from "@opennextjs/aws/adapters/config/util.js";
+import * as buildHelper from "@opennextjs/aws/build/helper.js";
+
+/**
+ * Returns whether the project is using a Node.js middleware.
+ *
+ * @param options
+ * @returns Whether the project is using a Node.js middleware
+ */
+export function useNodeMiddleware(options: buildHelper.BuildOptions): boolean {
+	const buildOutputDotNextDir = path.join(options.appBuildOutputPath, ".next");
+
+	// Look for the edge middleware
+	const middlewareManifest = loadMiddlewareManifest(buildOutputDotNextDir);
+	const edgeMiddleware = middlewareManifest.middleware["/"];
+	if (edgeMiddleware) {
+		// The app uses an edge middleware
+		return false;
+	}
+
+	// Look for the node middleware
+	const functionsConfigManifest = loadFunctionsConfigManifest(buildOutputDotNextDir);
+	return Boolean(functionsConfigManifest?.functions["/_middleware"]);
+}