Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: Verify new installation #131

Open
bonh opened this issue Feb 17, 2025 · 6 comments
Open

JOSS: Verify new installation #131

bonh opened this issue Feb 17, 2025 · 6 comments

Comments

@bonh
Copy link

bonh commented Feb 17, 2025

Perhaps you'd like to add an automated quantitative tests so that I can verify my installation?

Right now I can run through your examples and qualitatively verify the results but a more systematic approach would be better, right?

@openjournals/joss-reviews#7710

@ebknudsen
Copy link
Collaborator

ebknudsen commented Feb 28, 2025

Agreed - I will add something like that, in addition to the pytest-based automated tests, which are run for all PRs. Although I should mention that these are run at the "new" repo location united-neux/CAD_to_OpenMC

@ebknudsen
Copy link
Collaborator

There is now a self-contained test script in the tests directory with exactly this purpose, which checks that an actual geometry, albeit a very simple one, get triangularized in the expected way.

@ebknudsen ebknudsen reopened this Mar 7, 2025
@bonh
Copy link
Author

bonh commented Mar 11, 2025

When I try to execute the test script I get ModuleNotFoundError: No module named 'h5py'. I installed the code via conda so not from branch paper_joss but I guess that h5py is required for other stuff too and then it should be part of the conda recipe, right?

@ebknudsen
Copy link
Collaborator

You are entirely right - I missed this one since other stuff depends on it. This has been taken care of by #145

@bonh
Copy link
Author

bonh commented Mar 17, 2025

It seems that installing CadQuery via pip misses some depedencies? I installed CAD_to_OpenMC from source using branch joss_paper. Running test_self_contained.py results in ModuleNotFoundError: No module named 'typing_extensions' which is used by CadQuery as far as I understand. Installing typing_extensions resolves this issue but then ModuleNotFoundError: No module named 'multimethod' . I now that this is more a CadQuery issue but it seems to me, that the CadQuery people recommend Conda for installing their software?

@ebknudsen
Copy link
Collaborator

This was indeed an upstream issue, related to numpy transitioning from 1.x to 2.y which was not entirely reflected in cadquery's pip-stream. It works now with the new release (pip: 1.0.1-2), btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants