-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS: Verify new installation #131
Comments
Agreed - I will add something like that, in addition to the pytest-based automated tests, which are run for all PRs. Although I should mention that these are run at the "new" repo location united-neux/CAD_to_OpenMC |
There is now a self-contained test script in the tests directory with exactly this purpose, which checks that an actual geometry, albeit a very simple one, get triangularized in the expected way. |
When I try to execute the test script I get |
You are entirely right - I missed this one since other stuff depends on it. This has been taken care of by #145 |
It seems that installing |
This was indeed an upstream issue, related to numpy transitioning from 1.x to 2.y which was not entirely reflected in cadquery's pip-stream. It works now with the new release (pip: 1.0.1-2), btw. |
Perhaps you'd like to add an automated quantitative tests so that I can verify my installation?
Right now I can run through your examples and qualitatively verify the results but a more systematic approach would be better, right?
@openjournals/joss-reviews#7710
The text was updated successfully, but these errors were encountered: