Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4200 - Vite #4201

Draft
wants to merge 12 commits into
base: development
Choose a base branch
from
Draft

4200 - Vite #4201

wants to merge 12 commits into from

Conversation

sorja
Copy link
Contributor

@sorja sorja commented Jan 8, 2025 •
edited
Loading

Note:
Use react-swc: https://github.com/vitejs/vite-plugin-react-swc

Draft?:

  • Performance issues on first load

Notable changes:

TS:

Remove unnecessary namespace imports:

-- Before
import * as express from 'express'

-- After
import express from 'express'
SCSS:

Update imports to start from client:

-- Before
@import 'src/client/style/partials';

-- After
@import 'client/style/partials';

Remove deprecated lighten and darken:

-- Before
...
background-color: darken($ui-bg, 4%);
...
-- After

@use 'sass:color';
...
background-color: color.adjust($ui-bg, $lightness: 4%);
...

@sorja sorja linked an issue Jan 8, 2025 that may be closed by this pull request
Vite #4200
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vite
1 participant
@sorja