Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add columns to "pay your supplier" report #13013

Open
RachL opened this issue Dec 2, 2024 · 7 comments · May be fixed by #13037
Open

Add columns to "pay your supplier" report #13013

RachL opened this issue Dec 2, 2024 · 7 comments · May be fixed by #13037
Assignees
@chahmedejaz
Labels
funded feature
Milestone
Flower farms

Comments

@RachL
Copy link
Contributor

RachL commented Dec 2, 2024 •
edited
Loading

⚠️ Please use clockify code #12476 Flower Farms

Description

- As a: enterprise user
- On page: /admin/reports/suppliers/pay_your_suppliers
- I want to be able to do: See two new columns in "Pay your suppliers" report :

  • column showing the value "yes/no" with title "Producer charges GST?" The value of this column should match producer's settings in /admin/enterprises/NAME/edit#/business_details_panel
  • add Total tax on product

I've added both in the original example here columns D and T: https://docs.google.com/spreadsheets/d/1XDi3whY2h2DnHQtYS0Fbogr_VTJmYhAXzt1p9ElBBbM/edit?gid=0#gid=0

For this second item we should have :

Total = Total excl. tax + total tax (in the spreadsheet W = R + V)
Total excl. tax = total excl. fees and tax + total fees excl. tax (in the spreadsheet R = Q + S)
Total tax = Total tax on product + total tax on fees (V = T + U)

as no one has build integration based on this report yet, we can add these as default columns

Acceptance Criteria & Tests

  1. Log in as hub selling items from several producers
  2. Check data for suppliers who are tax registered and not tax registered
  3. If they are not tax registered, columns with total tax (t,U,V in the spreadsheet) should be equal to 0
@RachL RachL added this to the Flower farms milestone Dec 2, 2024
@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Dec 2, 2024
@RachL RachL moved this from All the things 💤 to Dev ready 👋 in OFN Delivery board Dec 2, 2024
@RachL RachL mentioned this issue Dec 2, 2024
Merged
4 tasks
@chahmedejaz chahmedejaz self-assigned this Dec 2, 2024
@tschumilas
Copy link

one comment to clarify on Rache's example linked above:
If the supplier is not tax registered - then no taxes (neither product taxes, nor fee taxes) are paid out. so column S would also be empty.

@RachL
Copy link
Contributor Author

RachL commented Dec 2, 2024 •
edited
Loading

@tschumilas S is total fees excluding tax, so we could have fees on a producer that is not registered, would that be correct?

@chahmedejaz chahmedejaz moved this from Dev ready 👋 to In Progress ⚙ in OFN Delivery board Dec 3, 2024
@chahmedejaz
Copy link
Collaborator

Update:

  • Both columns are added to the report as per the description
  • I'll wait for the feedback on this before working on automated specs

Thanks

@tschumilas
Copy link

sorry - missed the comment above. YES - @RachL this is correct - column S - total fees excluding tax - would have only the fees and not the tax on the fees if a producer is not tax registered.

@RachL
Copy link
Contributor Author

RachL commented Dec 11, 2024

@chahmedejaz all good for you?

@chahmedejaz
Copy link
Collaborator

Thanks both for the feedback. All good, I'll finalize it now. 🙂

@chahmedejaz chahmedejaz linked a pull request Dec 12, 2024 that will close this issue
Open
4 tasks
@chahmedejaz
Copy link
Collaborator

Update:

  • The PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chahmedejaz chahmedejaz

Labels
funded feature
Projects
OFN Delivery board
Status: In Progress ⚙
Milestone
Flower farms
Development

Successfully merging a pull request may close this issue.

Add columns to "pay your supplier" report chahmedejaz/openfoodnetwork
3 participants
@RachL @tschumilas @chahmedejaz