-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Customer][Order->Edit] Inconsistent table format on (editable) order confirmation page #10261
Comments
Maybe introduced when we added 'Back to Website' button (not visible on your screenshot)? |
Hey @jibees , Sorry, I guess I should have been more explicit 🙈 I've edited above. This will lead the user to the order confirmation screen. |
Found it. openfoodnetwork/app/webpacker/css/darkswarm/cart-page.scss Lines 12 to 14 in fd44697
the |
Yes, I can see it too in order confirmation pages (either editing or after checkout), but only for editable orders. Is that the case, on that pic @RachL ? |
Yep! |
Hello, is this issue still open? If so, I would love to work on this! :) Thank you! |
Sure, thank you @ashwini-seshadri 👍 |
Thank you @ashwini-seshadri! |
I can still repro the gap on Firefox 130.0.1, but as mentioned in the original message, it doesn't happen on Chrome. I also found as potential fix the same thing that was brought up in #10261 (comment). The If this issue is still up for grab, can I look into preparing a PR for these changes? |
Sure go ahead @ndossougbete 👍 |
I took some time to look into it today, and I need to correct the statement in my comment above. I think it will be more complicated. The fix added in PR #10103 to address issue #9976 does not seem to be working anymore. Repro steps:
One one hand I don't quite understand why the change to make the
Chrome seems to handle the "cells try to become as small as possible" part better than Firefox, which is why a gap can show up. I found an article mentioning that it might cause some accessiblity issues. And overall, the whole body still scrolls on mobile Chrome & Firefox when a long string without spaces is included in the table. On Firefox is extra bad, compare outcome of executing the snippet here: https://stackoverflow.com/a/48736763. Other difference, in Chrome the "Back to store" button seems to have the wrong size, while in Firefox it matches the size of the buttons below. I'll have another look when I have some time. Hopefully I missed some simple fix, but maybe it will take a more comprehensive rewrite of the markup to fix this. Maybe CSS- All that to say that I'll hold off of submitting a PR just removing the And please let me know if I should fork the general table/scrolling issues of these screens to a separate issue. |
Hi! I gave up on trying to get the table to work on mobile, and created PR #13010 to fix the bug initially mentioned here. I think the table will never work properly on mobile and it would be best to try an alternate layout to display this info without needing to scroll. An interpretation of this (that still needs a lot of work to be anything close to shippable) could be something like: |
Description
For editable orders - i.e., orders which can be cancelled or line items amount changed by the customer, while the OC is open - the table in the order confirmation page shows an inconsistent format.
Expected Behavior
Table format should be consistent.
Actual Behaviour
Table formatting is inconsistent (blank space is visible).
Steps to Reproduce
/account#/orders
and clickEdit
for that order -> Notice the blank space on the table.(This affects only order confirmation page while the OC is open:
4. As an admin: Close the order cycle
5. As a customer: Edit that order -> notice the formatting is correct)
OR:
Skip all steps and visit:
https://staging.openfoodnetwork.org.uk/orders/R632653401?order_token=a629d72866356506
Animated Gif/Screenshot
Workaround
Does not affect functionality.
Severity
bug-s5: we can live with it, only a few users impacted
Your Environment
Possible Fix
The text was updated successfully, but these errors were encountered: