Skip to content

Commit 8a886fd

Browse files
committed
fix: fix tests
1 parent 12b2ef4 commit 8a886fd

File tree

3 files changed

+29
-6
lines changed

3 files changed

+29
-6
lines changed

lms/djangoapps/courseware/tests/test_lti_integration.py

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from collections import OrderedDict
66

77
from unittest import mock
8+
from unittest.mock import patch
89
import urllib
910
import oauthlib
1011
from django.conf import settings
@@ -16,6 +17,7 @@
1617
from openedx.core.lib.url_utils import quote_slashes
1718
from xmodule.modulestore.tests.django_utils import SharedModuleStoreTestCase # lint-amnesty, pylint: disable=wrong-import-order
1819
from xmodule.modulestore.tests.factories import CourseFactory, BlockFactory # lint-amnesty, pylint: disable=wrong-import-order
20+
from xmodule.tests.helpers import mock_render_template
1921

2022

2123
class TestLTI(BaseTestXmodule):
@@ -115,14 +117,26 @@ def mocked_sign(self, *args, **kwargs):
115117
patcher.start()
116118
self.addCleanup(patcher.stop)
117119

118-
def test_lti_constructor(self):
120+
@patch('xblock.utils.resources.ResourceLoader.render_django_template', side_effect=mock_render_template)
121+
def test_lti_constructor(self, mock_render_django_template):
119122
generated_content = self.block.student_view(None).content
120-
expected_content = self.runtime.render_template('lti.html', self.expected_context)
123+
124+
if settings.USE_EXTRACTED_LTI_BLOCK:
125+
expected_content = self.runtime.render_template('templates/lti.html', self.expected_context)
126+
mock_render_django_template.assert_called_once()
127+
else:
128+
expected_content = self.runtime.render_template('lti.html', self.expected_context)
121129
assert generated_content == expected_content
122130

123-
def test_lti_preview_handler(self):
131+
@patch('xblock.utils.resources.ResourceLoader.render_django_template', side_effect=mock_render_template)
132+
def test_lti_preview_handler(self, mock_render_django_template):
124133
generated_content = self.block.preview_handler(None, None).body
125-
expected_content = self.runtime.render_template('lti_form.html', self.expected_context)
134+
135+
if settings.USE_EXTRACTED_LTI_BLOCK:
136+
expected_content = self.runtime.render_template('templates/lti_form.html', self.expected_context)
137+
mock_render_django_template.assert_called_once()
138+
else:
139+
expected_content = self.runtime.render_template('lti_form.html', self.expected_context)
126140
assert generated_content.decode('utf-8') == expected_content
127141

128142

xmodule/tests/test_lti20_unit.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,22 @@
44
import datetime
55
import textwrap
66
import unittest
7+
from django.conf import settings
78
from unittest.mock import Mock
89

910
from pytz import UTC
1011
from xblock.field_data import DictFieldData
1112

12-
from xmodule.lti_2_util import LTIError
1313
from xmodule.lti_block import LTIBlock
1414
from xmodule.tests.helpers import StubUserService
1515

1616
from . import get_test_system
1717

18+
if settings.USE_EXTRACTED_LTI_BLOCK:
19+
from xblocks_contrib.lti.lti_2_util import LTIError
20+
else:
21+
from xmodule.lti_2_util import LTIError
22+
1823

1924
class LTI20RESTResultServiceTest(unittest.TestCase):
2025
"""Logic tests for LTI block. LTI2.0 REST ResultService"""

xmodule/tests/test_lti_unit.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,16 @@
2222

2323
from common.djangoapps.xblock_django.constants import ATTR_KEY_ANONYMOUS_USER_ID
2424
from xmodule.fields import Timedelta
25-
from xmodule.lti_2_util import LTIError
2625
from xmodule.lti_block import LTIBlock
2726
from xmodule.tests.helpers import StubUserService
2827

2928
from . import get_test_system
3029

30+
if settings.USE_EXTRACTED_LTI_BLOCK:
31+
from xblocks_contrib.lti.lti_2_util import LTIError
32+
else:
33+
from xmodule.lti_2_util import LTIError
34+
3135

3236
@override_settings(LMS_BASE="edx.org")
3337
class LTIBlockTest(TestCase):

0 commit comments

Comments
 (0)