Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll to full report upon clicking group progress link #1439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marlonkeating
Copy link
Contributor

Jira Ticket

This change adds a fragment to the 'View group progress' url, which triggers the Learner Progress Report page to scroll down to the Full Report section when it loads.

Testing

  • Go to the admin-portal repo and run npm run start:stage
  • Navigate to https://localhost.stage.edx.org:1991/alc-general/admin/people-management
  • Click into any group
  • Click 'view group progress'
  • Verify upon navigating to Learner Progress Report, the frame scrolls down to Full Report (may need to shrink browser window to see this, as LPR content doesn't render on stage)

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.43%. Comparing base (c79ab87) to head (9436e71).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1439      +/-   ##
==========================================
+ Coverage   86.41%   86.43%   +0.02%     
==========================================
  Files         660      660              
  Lines       14934    14942       +8     
  Branches     3109     3174      +65     
==========================================
+ Hits        12905    12915      +10     
+ Misses       1965     1957       -8     
- Partials       64       70       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant