fix: budget invite duplicate text entry bug

[marlonkeating]

Jira Ticket

This change fixes an issue around duplicate emails being input on the Learner Credit Browse and Enroll Add Members modal.

Testing

• Go to the admin-portal repo and run npm run start:stage
• Navigate to https://localhost.stage.edx.org:1991/timtam/admin/learner-credit/ecdfe8e7-94cd-461b-bd9d-205094f04f46/members
• Click 'New members'
• Verify emails can be typed in without triggering duplicate warning

For all changes

• Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

• Ensure to attach screenshots
• Ensure to have UX team confirm screenshots

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (6d19d00) to head (2aa71bc).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1422   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         660      660           
  Lines       14921    14921           
  Branches     3167     3167           
=======================================
  Hits        12902    12902           
  Misses       1949     1949           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jesperhodge]

Great work. Works very smoothly now.

Could we add a test for this? I feel this could have ideally been caught by a test in the first place, and if we don't add a test now, we risk this breaking again in the future.

Maybe it would be a good time to have a look if there's any other aspect of this feature that's not sufficiently tested while doing that?

[jesperhodge]

If you don't mind, could you just have another look at the test? I left a comment there.

[jesperhodge]

Hey as far as I can tell, this test checks that when you enter a valid email, it doesn't display an error. I guess it's a good test to have if it isn't there yet, but not quite sure how it tests the bug that was fixed here?

I noticed that when I change the code back to the previous broken state, the test still succeeds. I am feeling that that could be a bit misleading and instill false confidence.

What do you think about adding a test should not produce a duplicate email when editing an email? The test would enter an email address, wait for the debounce, and then edit the same line. It would then not just look for the warning but actually check if a duplicate was in fact produced. And it would be great to make sure that the test fails until the change you made here is active, so it doesn't create false positives.