Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign button grey out #1418

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Conversation

jesperhodge
Copy link
Member

@jesperhodge jesperhodge commented Feb 6, 2025

Description

On the Group assignment modal, when entering email addresses and then deleting them with backspace, the assign button stayed grayed out. This fixes it.

Links

JIRA ticket
video

Testing instructions

  • Go to an enterprise with existing Learner Groups and existing courses
  • Go to Leaner Credit Management
  • Click on the "catalog" tab
  • Click on "Assign" and select a date -> The Assign modal should open
  • The Assign button on the bottom should be disabled
  • assign a group via the drop down
  • The assign button should be enabled
  • Enter an email address in the text field
  • Delete the email from the text field via backspace again
  • The assign button should still be enabled

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (1010d7d) to head (4419d25).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
+ Coverage   86.44%   86.46%   +0.02%     
==========================================
  Files         660      660              
  Lines       14923    14921       -2     
  Branches     3167     3159       -8     
==========================================
+ Hits        12900    12902       +2     
+ Misses       1951     1949       -2     
+ Partials       72       70       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesperhodge jesperhodge marked this pull request as ready for review February 10, 2025 21:38
@jesperhodge jesperhodge merged commit 68a5b00 into master Feb 12, 2025
6 checks passed
@jesperhodge jesperhodge deleted the fix--course-assignment-group-bug branch February 12, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants