Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates groups help center link #1416

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Feb 4, 2025

Description

Updates links to the groups help center doc and adds a subtitle in the Create group modal.
JIRA

Screenshot 2025-02-04 at 2 50 17 PM

Testing

  1. checkout branch and run npm run start:stage
  2. navigate to https://localhost.stage.edx.org:1991/alc-general/admin/people-management and click on Create group. verify that you see the subtitle and clicking on the Learn more link takes you to the help center.
  3. Upload a CSV file with a random email in the Create group modal so that an error card will appear. Click on the the link and verify that it navigates you to the help center.
  4. Navigate to a groups detail page and click on Add members. Verify that clicking on the Learn more link in that modal takes you to the help center.
  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review February 4, 2025 23:16
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.43%. Comparing base (64429eb) to head (c11229b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1416   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files         660      660           
  Lines       14888    14889    +1     
  Branches     3162     3162           
=======================================
+ Hits        12869    12870    +1     
  Misses       1947     1947           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 merged commit a3fe219 into master Feb 5, 2025
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9950 branch February 5, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants