Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding different warning message for groups #1415

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Feb 4, 2025

Screenshot 2025-02-05 at 12 20 43 AM

Jira ticket

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@kiram15 kiram15 requested a review from a team February 4, 2025 18:04
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.45%. Comparing base (a3fe219) to head (27f246f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
+ Coverage   86.43%   86.45%   +0.01%     
==========================================
  Files         660      660              
  Lines       14889    14897       +8     
  Branches     3100     3164      +64     
==========================================
+ Hits        12870    12879       +9     
+ Misses       1950     1946       -4     
- Partials       69       72       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -122,7 +122,6 @@ class LearnerActivityTable extends React.Component {

render() {
const { activity, id } = this.props;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unnecessary whitespace change

@kiram15 kiram15 merged commit b842e83 into master Feb 5, 2025
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9949 branch February 5, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants