Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to valueof when doing unix conversion #1320

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

brobro10000
Copy link
Member

When doing comparisons of date using dates and timestamp, use the milliseconds conversion to increase precision. With this change the start date logic comparison of "Is the earliest of 2 start dates (enrollStart OR start) before the subsidy expiration date minus 14 day threshold.", the resolved logic is now correct.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (e7aaa47) to head (315753d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...components/learner-credit-management/data/utils.js 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
- Coverage   85.60%   85.59%   -0.01%     
==========================================
  Files         575      575              
  Lines       12672    12678       +6     
  Branches     2691     2646      -45     
==========================================
+ Hits        10848    10852       +4     
- Misses       1762     1766       +4     
+ Partials       62       60       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 force-pushed the hu/ent-enrollstart-fix-2 branch from 4d3bfa1 to 3bb3ba3 Compare September 25, 2024 14:21
@brobro10000 brobro10000 force-pushed the hu/ent-enrollstart-fix-2 branch from 4fd9729 to 7bb2dca Compare September 25, 2024 15:23
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a suggestion to update a comment related to late enrollment.

@brobro10000 brobro10000 force-pushed the hu/ent-enrollstart-fix-2 branch from fb3fa97 to 315753d Compare September 25, 2024 15:52
@brobro10000 brobro10000 merged commit 932b456 into master Sep 25, 2024
4 of 6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-enrollstart-fix-2 branch September 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants