-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: switch to valueof when doing unix conversion #1320
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
==========================================
- Coverage 85.60% 85.59% -0.01%
==========================================
Files 575 575
Lines 12672 12678 +6
Branches 2691 2646 -45
==========================================
+ Hits 10848 10852 +4
- Misses 1762 1766 +4
+ Partials 62 60 -2 ☔ View full report in Codecov by Sentry. |
4d3bfa1
to
3bb3ba3
Compare
4fd9729
to
7bb2dca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a suggestion to update a comment related to late enrollment.
fb3fa97
to
315753d
Compare
When doing comparisons of date using dates and timestamp, use the milliseconds conversion to increase precision. With this change the start date logic comparison of "Is the earliest of 2 start dates (enrollStart OR start) before the subsidy expiration date minus 14 day threshold.", the resolved logic is now correct.
For all changes
Only if submitting a visual change