feat: display retired badge on retired budgets #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Jan 23, 2024
| <Badge variant={badgeVariant}>{ status }</Badge> | ||
| <span className="small">{term} { formatDate(date) }</span> | ||
| <Badge variant={badgeVariant}>{status}</Badge> | ||
| {(term && date) && ( |
There was a problem hiding this comment.
Only render the term/date if present
adamstankiewicz
force-pushed
the
ags/retired-admin-budgets
branch
from
cf79c5e to
276f384
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
+ Coverage 85.39% 85.41% +0.02%
==========================================
Files 496 496
Lines 10712 10720 +8
Branches 2247 2253 +6
==========================================
+ Hits 9148 9157 +9
+ Misses 1522 1521 -1
Partials 42 42 ☔ View full report in Codecov by Sentry. |
macdiesel
approved these changes
Jan 23, 2024
pwnage101
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: https://2u-internal.atlassian.net/browse/ENT-8303
Changes
infovariantBadgeon the budget cards in the overview page route and no date displayed. The CTA is using theoutline-primarybutton variant.infovariantBadgeon the budget detail page and no date displayed.For all changes
Only if submitting a visual change