Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation issue of admin card on learners page #1156

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Jan 19, 2024
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/admin-card-navigation branch from 918c402 to a5d5b32 Compare January 19, 2024 10:48
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1b78b7) 85.33% compared to head (a5d5b32) 85.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1156   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files         495      495           
  Lines       10650    10652    +2     
  Branches     2232     2232           
=======================================
+ Hits         9088     9090    +2     
  Misses       1520     1520           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi merged commit d84d226 into master Jan 19, 2024
5 checks passed
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi deleted the Ali-Abbas/admin-card-navigation branch January 19, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants