Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONOT MERGE: Revert: upgrade react router to v6 (#1001) and update path generation to use generatePath (#1154) #1155

Closed
wants to merge 2 commits into from

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (c1b78b7) 85.33% compared to head (ad0d292) 85.42%.

Files Patch % Lines
src/components/Admin/AdminSearchForm.jsx 0.00% 4 Missing ⚠️
src/components/App/index.jsx 0.00% 4 Missing ⚠️
...nents/ContentHighlights/ContentHighlightRoutes.jsx 71.42% 2 Missing ⚠️
...c/components/EnterpriseApp/EnterpriseAppRoutes.jsx 75.00% 2 Missing ⚠️
src/components/TableComponent/index.jsx 0.00% 2 Missing ⚠️
src/components/CodeManagement/ManageCodesTab.jsx 80.00% 1 Missing ⚠️
src/components/CodeSearchResults/index.jsx 66.66% 1 Missing ⚠️
...ights/HighlightStepper/ContentHighlightStepper.jsx 66.66% 1 Missing ⚠️
src/components/EnterpriseApp/index.jsx 66.66% 1 Missing ⚠️
...c/components/RequestCodesPage/RequestCodesForm.jsx 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
+ Coverage   85.33%   85.42%   +0.08%     
==========================================
  Files         495      494       -1     
  Lines       10650    10625      -25     
  Branches     2232     2219      -13     
==========================================
- Hits         9088     9076      -12     
+ Misses       1520     1507      -13     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irfanuddinahmad irfanuddinahmad changed the title Revert: upgrade react router to v6 (#1001) and update path generation to use generatePath (#1154) DONOT MERGE: Revert: upgrade react router to v6 (#1001) and update path generation to use generatePath (#1154) Jan 19, 2024
@irfanuddinahmad irfanuddinahmad changed the title DONOT MERGE: Revert: upgrade react router to v6 (#1001) and update path generation to use generatePath (#1154) Revert: upgrade react router to v6 (#1001) and update path generation to use generatePath (#1154) Jan 19, 2024
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi changed the title Revert: upgrade react router to v6 (#1001) and update path generation to use generatePath (#1154) DONOT MERGE: Revert: upgrade react router to v6 (#1001) and update path generation to use generatePath (#1154) Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants