[pull] main from trustyai-explainability:main #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions (#601) * Generalize configmap and route creation, reconciliation functions * Address coderabbit comments
* Second round of function standardization * Update controllers/gorch/deployment.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* feat: Add OCI artifact output support to LMEvalJob (#529) * feat: Add subject to LMEval CRD's OCI outputs (#530) * feat: Add subject to LMEval CRD's OCI outputs * chore: Add more test cases * let's log the CM reading logic Signed-off-by: tarilabs <[email protected]> * Fix test compilation errors by adding PermissionConfig parameter Co-Authored-By: Claude <[email protected]> Signed-off-by: tarilabs <[email protected]> * params.env bump Signed-off-by: tarilabs <[email protected]> * debug: GHA results of params.env(s) Signed-off-by: tarilabs <[email protected]> * replace Token with (.)DockerConfigJson Signed-off-by: tarilabs <[email protected]> * bump images to 6455873 Signed-off-by: tarilabs <[email protected]> * regenerate images Signed-off-by: tarilabs <[email protected]> * need images to 209263a Signed-off-by: tarilabs <[email protected]> * regenerate images Signed-off-by: tarilabs <[email protected]> * need the skopeo dependency Signed-off-by: tarilabs <[email protected]> * need params at e26591f Signed-off-by: tarilabs <[email protected]> * replace `registry` as string instead of SecretKeyRef Signed-off-by: tarilabs <[email protected]> * need params env at 51fd641 Signed-off-by: tarilabs <[email protected]> * regenerate images Signed-off-by: tarilabs <[email protected]> * regenerate images Signed-off-by: tarilabs <[email protected]> * params.env at c2ccdf4 Signed-off-by: tarilabs <[email protected]> * implement TAG if missing is Job name Signed-off-by: tarilabs <[email protected]> * params.env at dd6d643 Signed-off-by: tarilabs <[email protected]> * remove no-longer needed Path since it's not really known before-hand to the end-user Signed-off-by: tarilabs <[email protected]> * remove CABundle Signed-off-by: tarilabs <[email protected]> * params.env at 4b1e455 Signed-off-by: tarilabs <[email protected]> * regenerate images Signed-off-by: tarilabs <[email protected]> * params.env at f05fef7 Signed-off-by: tarilabs <[email protected]> * get things back into place for merging Signed-off-by: tarilabs <[email protected]> * feedback: use Tag regex from OCI spec see also https://github.com/opencontainers/distribution-spec/blob/e612a6e1e1bc717f9fa7e1feb4f05c8b6568754a/spec.md?plain=1#L164-L166 Signed-off-by: tarilabs <[email protected]> * feedback: internals to avoid OCI_PATH altogether Signed-off-by: tarilabs <[email protected]> * feedback: test rename Signed-off-by: tarilabs <[email protected]> * feedback: refactor cmd to "avoid repetitions" Signed-off-by: tarilabs <[email protected]> * implement test feedback: - add case where PVCManaged is specified (no OCI) and no spurious flag added - add case where PVC+OCI is specified, check no flag is missing Signed-off-by: tarilabs <[email protected]> --------- Signed-off-by: tarilabs <[email protected]> Co-authored-by: Rui Vieira <[email protected]> Co-authored-by: Claude <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )