Skip to content

Commit 33805b8

Browse files
committed
RHAIENG-287: fix(kustomization.yaml): abbreviate namePrefix to resolve Kubernetes label character limit issue
``` kubernetes namespace events [INFO] Running command (('kubectl get events',), {'shell': True}) LAST SEEN TYPE REASON OBJECT MESSAGE 71s Warning FailedCreate statefulset/jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook create Pod jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-0 in StatefulSet jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook failed error: Pod "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-0" is invalid: metadata.labels: Invalid value: "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-7d69c59fc6": must be no more than 63 characters ``` ``` + notebook_workload_name=jupyter-pt-llmcompress-ubi9-python-3-12-notebook-0 + _handle_test + local notebook_id= ++ _get_notebook_id ++ local notebook_id= ++ local accelerator=cuda ++ accelerator= ++ case "${notebook_workload_name}" in ++ printf '%s\n' 'No matching condition found for jupyter-pt-llmcompress-ubi9-python-3-12-notebook-0.' ++ exit 1 ```
1 parent 72a6741 commit 33805b8

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/kustomization.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
---
22
apiVersion: kustomize.config.k8s.io/v1beta1
33
kind: Kustomization
4-
namePrefix: jupyter-pytorch-llmcompressor-ubi9-python-3-12-
4+
# have to abbreviate the prefix, otherwise we'd go over the 63 character limit
5+
# > Pod "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-0" is invalid: metadata.labels: Invalid value: "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-7d69c59fc6": must be no more than 63 characters
6+
namePrefix: jupyter-pt-llmcompress-ubi9-python-3-12-
57
labels:
68
- includeSelectors: true
79
pairs:

scripts/test_jupyter_with_papermill.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,9 @@ function _get_notebook_id() {
346346
*${jupyter_pytorch_notebook_id}-*)
347347
notebook_id="${accelerator:+$accelerator/}${jupyter_pytorch_notebook_id}"
348348
;;
349+
*${jupyter_pytorch_llmcompressor_notebook_shortened_id}-*)
350+
notebook_id="${accelerator:+$accelerator/}${jupyter_pytorch_llmcompressor_notebook_full_id}"
351+
;;
349352
*)
350353
printf '%s\n' "No matching condition found for ${notebook_workload_name}."
351354
exit 1
@@ -387,6 +390,8 @@ jupyter_datascience_notebook_id='datascience'
387390
jupyter_trustyai_notebook_id='trustyai'
388391
jupyter_pytorch_notebook_id='pytorch'
389392
jupyter_tensorflow_notebook_id='tensorflow'
393+
jupyter_pytorch_llmcompressor_notebook_shortened_id='pt-llmcompress'
394+
jupyter_pytorch_llmcompressor_notebook_full_id="pytorch-llmcompressor"
390395

391396
notebook_name=$( _get_notebook_name "${test_target}" )
392397
python_flavor="python-${test_target//*-python-/}" # <-- python-3.11

0 commit comments

Comments
 (0)