IDP-43-modular: code copilot feedbaack

Author: hminaee-tc

cpk_lib_python_github/github_app_token_generator_package/github_app_token_generator/github_api.py

@@ -148,7 +148,10 @@ def revoke_installation_token(self, token: str) -> bool:
             return True
 
         except requests.exceptions.HTTPError as http_error:
-            if response.status_code == 404:
+            if (
+                http_error.response is not None
+                and http_error.response.status_code == 404
+            ):
                 logger.warning("Token not found or already revoked")
                 return False
             logger.error("HTTP error occurred while revoking token: %s", http_error)

cpk_lib_python_github/github_app_token_generator_package/tests/test_github_api.py

@@ -172,7 +172,6 @@ def test_get_installation_access_token_connection_error(
         self, github_api_client, sample_jwt_token, sample_installation_id
     ):
         """Test connection error (no mock response registered)."""
-        # Don't register any mock response to simulate connection error
 
         with pytest.raises(requests.exceptions.RequestException):
             github_api_client.get_installation_access_token(
@@ -255,7 +254,6 @@ def test_list_installations_network_error(
         self, github_api_client, sample_jwt_token
     ):
         """Test installations listing with network error."""
-        # Don't add any responses to simulate network error
 
         with pytest.raises(requests.exceptions.RequestException):
             github_api_client.list_installations(sample_jwt_token)
@@ -373,7 +371,6 @@ def test_validate_token_network_error(
         self, github_api_client, sample_installation_token
     ):
         """Test token validation with network error."""
-        # Don't add any responses to simulate network error
 
         result = github_api_client.validate_token(sample_installation_token)
 
@@ -458,7 +455,6 @@ def test_revoke_installation_token_network_error(
         self, github_api_client, sample_installation_token
     ):
         """Test token revocation with network error."""
-        # Don't add any responses to simulate network error
 
         with pytest.raises(requests.exceptions.RequestException):
             github_api_client.revoke_installation_token(sample_installation_token)
@@ -753,7 +749,6 @@ def test_get_accessible_repositories_via_token_network_error(
         self, github_api_client, sample_installation_token
     ):
         """Test repositories retrieval via token with network error."""
-        # Don't add any responses to simulate network error
 
         repos = github_api_client.get_accessible_repositories_via_token(
             sample_installation_token