Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteToFile signature doesn't make sense #4

Open
afeld opened this issue Jul 20, 2016 · 0 comments
Open

WriteToFile signature doesn't make sense #4

afeld opened this issue Jul 20, 2016 · 0 comments
Labels
HighBar

Comments

@afeld
Copy link
Member

afeld commented Jul 20, 2016

The signature is a method on the Document interface, but it doesn't actually affect/use that file. Current usage:

doc.WriteToFile(path, content)

The usage would make more sense to me as one of the following:

doc.WriteToFile(content)
// or
WriteToFile(path, content)
@mogul mogul added the HighBar label Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HighBar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mogul @afeld