Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove BatchKey in site encoders #328

Open
peterdudfield opened this issue Feb 28, 2025 · 3 comments
Open

remove BatchKey in site encoders #328

peterdudfield opened this issue Feb 28, 2025 · 3 comments
Assignees
@devojyotimisra
Labels
good first issue Good for newcomers

Comments

@peterdudfield
Copy link
Contributor

peterdudfield commented Feb 28, 2025 •
edited
Loading

We are trying to get ride of ocf_datapipes from this repo.
#308

It would be great to remove it from
https://github.com/openclimatefix/PVNet/blob/main/pvnet/models/multimodal/site_encoders/encoders.py#L7

They can be replaces with strings for now
@peterdudfield peterdudfield added enhancement New feature or request good first issue Good for newcomers and removed enhancement New feature or request labels Feb 28, 2025
@peterdudfield peterdudfield mentioned this issue Feb 28, 2025
Open
@devojyotimisra
Copy link

Hi @peterdudfield,

I would Like to solve this issue

@lambaaryan011
Copy link

Hey @devojyotimisra are you working on this or should replace me this issue

@devojyotimisra
Copy link

@lambaaryan011,
The job has been done, but the PR has not been accepted yet, you can look into something else I guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devojyotimisra devojyotimisra

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterdudfield @lambaaryan011 @devojyotimisra