Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save PVNet and ocf-data-sampler/ocf_datapipes version to model card when pushing to HF #326

Open
AUdaltsova opened this issue Feb 21, 2025 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AUdaltsova
Copy link
Contributor

Detailed Description

Now that we're transitioning between models that use ocf_datapipes and ones using different versions of ocf-data-sampler, it would be useful to save information on the versions of tools used to train it. I think it should go into the model card on HF under 'Software' (we currently have links to repos there, which default to ocf_datapipes regardless). I'd suggest to make the change somewhere in here in the model's save_pretrained method, but open to suggestions.

Ideally, it would automatically save the versions used, but this might require changes to have we save checkpoints, so everything is stored correctly. If this is not possible, maybe it can prompt the user to input the libraries and versions on save.

@AUdaltsova AUdaltsova added enhancement New feature or request contributions-welcome Good issue for open-source contribution labels Feb 21, 2025
@chaitanya-rdY
Copy link

@AUdaltsova , I would like to work on this issue. Could you please assign it to me?

@peterdudfield peterdudfield added good first issue Good for newcomers and removed contributions-welcome Good issue for open-source contribution labels Feb 26, 2025
@lambaaryan011
Copy link

Hello @peterdudfield,
I noticed that there hasn’t been any progress on this PR since last week. Could you please assign it to me?

@devojyotimisra
Copy link

Hey @peterdudfield,
I would like to work on this can you please assign this to me?

@chaitanya-rdY
Copy link

@devojyotimisra ,
Hey! I am currently working in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants