-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
GitHub OAuth consent screen uses personal ClawdHub app branding #2524
Copy link
Copy link
Open
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.area: securitySecurity, abuse prevention, or trust and safetySecurity, abuse prevention, or trust and safetybugSomething isn't workingSomething isn't workingclawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.impact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.
Metadata
Metadata
Assignees
Labels
P2Normal backlog priority with limited blast radius.Normal backlog priority with limited blast radius.area: securitySecurity, abuse prevention, or trust and safetySecurity, abuse prevention, or trust and safetybugSomething isn't workingSomething isn't workingclawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:needs-maintainer-reviewClawSweeper marked this issue as needing maintainer review before automation.ClawSweeper marked this issue as needing maintainer review before automation.clawsweeper:needs-product-decisionClawSweeper marked this issue as needing a product or behavior decision.ClawSweeper marked this issue as needing a product or behavior decision.clawsweeper:needs-security-reviewClawSweeper marked this issue as needing security-sensitive review.ClawSweeper marked this issue as needing security-sensitive review.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.impact:auth-providerAuth, provider routing, model choice, or SecretRef resolution may break.Auth, provider routing, model choice, or SecretRef resolution may break.impact:securitySecurity boundary, credential, authz, sandbox, or sensitive-data risk.Security boundary, credential, authz, sandbox, or sensitive-data risk.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
In progress
Problem
The GitHub OAuth consent screen for ClawHub sign-in currently presents the app as a personal/unofficial integration:
This is user-facing during web and CLI auth, so it undermines trust at the exact moment users are granting account access.
Evidence
Observed consent copy:
Repo findings:
convex/auth.tsconfigures Convex Auth with the Auth.js GitHub provider.AUTH_GITHUB_IDandAUTH_GITHUB_SECRET.auth.addHttpRoutes(http)mounts the OAuth endpoints under/api/auth/*.(CUSTOM_AUTH_SITE_URL ?? CONVEX_SITE_URL) + "/api/auth/callback/github".AUTH_GITHUB_ID,AUTH_GITHUB_SECRET,CONVEX_SITE_URL, andSITE_URLas deploy envs.Likely root cause
The production
AUTH_GITHUB_IDappears to point at a GitHub OAuth App namedClawdHubowned by Peter's personal account instead of an official OpenClaw/ClawHub-owned OAuth App.This is separate from the GitHub App backup/sync credentials (
GITHUB_APP_ID,GITHUB_APP_INSTALLATION_ID,GITHUB_APP_PRIVATE_KEY). Those do not control the user login consent screen.Expected behavior
The consent screen should show an official ClawHub-owned OAuth app, for example:
Proposed fix
ClawHub.https://clawhub.ai.https://wry-manatee-359.convex.site/api/auth/callback/github, unlessCUSTOM_AUTH_SITE_URLis intentionally set.Code/docs pointers
convex/auth.ts- GitHub provider andAUTH_GITHUB_ID/AUTH_GITHUB_SECRETusageconvex/http.ts-auth.addHttpRoutes(http)CONTRIBUTING.md- local callback URL shapespecs/deploy.md- production auth env varsvercel.json- current/api/*rewrite to the Convex site