Merge pull request #1312 from JulianKniephoff/enable-lints

Enable lints

Author: Arnei

eslint.config.js

@@ -11,19 +11,12 @@ export default [
     {
         rules: {
             // TODO: We want to turn these on eventually
-            "arrow-parens": "off",
             "camelcase": "off",
-            "comma-dangle": "off",
             "indent": "off",
-            "keyword-spacing": "off",
             "max-len": "off",
-            "no-extra-boolean-cast": "off",
             "no-tabs": "off",
             "no-unused-expressions": "off",
-            "object-curly-spacing": "off",
             "prefer-const": "off",
-            "quotes": "off",
-            "semi": "off",
             "spaced-comment": "off",
             "@typescript-eslint/await-thenable": "off",
             "@typescript-eslint/no-explicit-any": "off",
@@ -39,7 +32,7 @@ export default [
             "@typescript-eslint/no-unsafe-return": "off",
             "@typescript-eslint/require-await": "off",
             "@typescript-eslint/unbound-method": "off",
-        }
-    }
+        },
+    },
 ];
 

src/components/About.tsx

@@ -4,7 +4,7 @@ import NavBar from "./NavBar";
 import Footer from "./Footer";
 import { useTranslation } from "react-i18next";
 import { useLocation } from "react-router";
-import axios from 'axios';
+import axios from "axios";
 import i18n from "../i18n/i18n";
 import DOMPurify from "dompurify";
 
@@ -25,12 +25,12 @@ const About = () => {
 				setAboutContent(response.data);
 			})
 			.catch(error => {
-				axios.get(getURL(typeof i18n.options.fallbackLng === 'string' ? i18n.options.fallbackLng : 'en-US'))
+				axios.get(getURL(typeof i18n.options.fallbackLng === "string" ? i18n.options.fallbackLng : "en-US"))
 					.then(response => {
 						setAboutContent(response.data);
 					})
 					.catch(error => {
-						console.error('Error while fetching data:', error);
+						console.error("Error while fetching data:", error);
 						setAboutContent(t("ABOUT.NOCONTENT").toString());
 					});
 			});
@@ -47,12 +47,12 @@ const About = () => {
 					{
 						path: "/about/imprint",
 						accessRole: "ROLE_UI_USERS_VIEW",
-						text: "ABOUT.IMPRINT"
+						text: "ABOUT.IMPRINT",
 					},
 					{
 						path: "/about/privacy",
 						accessRole: "ROLE_UI_GROUPS_VIEW",
-						text: "ABOUT.PRIVACY"
+						text: "ABOUT.PRIVACY",
 					},
 				]}
 			>

src/components/Footer.tsx

@@ -19,13 +19,13 @@ const Footer: React.FC = () => {
 	const user = useAppSelector(state => getUserInformation(state));
 	const orgProperties = useAppSelector(state => getOrgProperties(state));
 
-	const version = (user?.ocVersion?.version ?? '')
-		.replace(/0\.0\.SNAPSHOT/, 'x')
-		.replace(/\.([0-9]+)\.0/, '.$1');
-	const lastModified = user?.ocVersion?.['last-modified']
-		? new Date(user.ocVersion['last-modified']).toISOString().substring(0, 10)
-		: 'unknown';
-	const aboutEnabled = (orgProperties['org.opencastproject.admin.display_about'] || 'false').toLowerCase() === 'true';
+	const version = (user?.ocVersion?.version ?? "")
+		.replace(/0\.0\.SNAPSHOT/, "x")
+		.replace(/\.([0-9]+)\.0/, ".$1");
+	const lastModified = user?.ocVersion?.["last-modified"]
+		? new Date(user.ocVersion["last-modified"]).toISOString().substring(0, 10)
+		: "unknown";
+	const aboutEnabled = (orgProperties["org.opencastproject.admin.display_about"] || "false").toLowerCase() === "true";
 
 	return (
 		<footer id="main-footer">
@@ -35,14 +35,14 @@ const Footer: React.FC = () => {
 					{user.ocVersion && (
 						<li>
 							{"Opencast "}
-							<Tooltip title={t('BUILD.VERSION')}><span>{version}</span></Tooltip>
+							<Tooltip title={t("BUILD.VERSION")}><span>{version}</span></Tooltip>
 							{user.isAdmin && (
 								<span>
 								{user.ocVersion.buildNumber && (
-									<>{" – "} <Tooltip title={t('BUILD.COMMIT')}><span>{user.ocVersion.buildNumber}</span></Tooltip></>
+									<>{" – "} <Tooltip title={t("BUILD.COMMIT")}><span>{user.ocVersion.buildNumber}</span></Tooltip></>
 								)}
 								{lastModified && (
-									<>{" – "} <Tooltip title={t('BUILD.DATE_DESC')}><span>{t("BUILD.BUILT_ON")} {lastModified}</span></Tooltip></>
+									<>{" – "} <Tooltip title={t("BUILD.DATE_DESC")}><span>{t("BUILD.BUILT_ON")} {lastModified}</span></Tooltip></>
 								)}
 								</span>
 							)}

src/components/Header.tsx

@@ -60,18 +60,18 @@ const Header = () => {
 	};
 
 	const showRegistrationModal = () => {
-		registrationModalRef.current?.open()
+		registrationModalRef.current?.open();
 	};
 
 	const showHotKeyCheatSheet = () => {
-		hotKeyCheatSheetModalRef.current?.open()
+		hotKeyCheatSheetModalRef.current?.open();
 	};
 
 	const toggleHotKeyCheatSheet = () => {
 		if (hotKeyCheatSheetModalRef.current?.isOpen?.()) {
-			hotKeyCheatSheetModalRef.current?.close?.()
+			hotKeyCheatSheetModalRef.current?.close?.();
 		} else {
-			hotKeyCheatSheetModalRef.current?.open()
+			hotKeyCheatSheetModalRef.current?.open();
 		}
 	};
 
@@ -86,9 +86,9 @@ const Header = () => {
     availableHotkeys.general.HOTKEY_CHEATSHEET.sequence,
     () => toggleHotKeyCheatSheet(),
 		{
-			description: t(availableHotkeys.general.HOTKEY_CHEATSHEET.description) ?? undefined
+			description: t(availableHotkeys.general.HOTKEY_CHEATSHEET.description) ?? undefined,
 		},
-    [toggleHotKeyCheatSheet]
+    [toggleHotKeyCheatSheet],
   );
 
 	useEffect(() => {
@@ -115,7 +115,7 @@ const Header = () => {
 		};
 
 		// Fetching health status information at mount
-		loadHealthStatus().then((r) => console.info(r));
+		loadHealthStatus().then(r => console.info(r));
 		// Fetch health status every minute
 		const interval = setInterval(() => dispatch(fetchHealthStatus()), 5000);
 
@@ -145,7 +145,7 @@ const Header = () => {
 					<div className="nav-dd lang-dd" id="lang-dd" ref={containerLang}>
 						<Tooltip active={!displayMenuLang} title={t("LANGUAGE")}>
 							<button className="lang" onClick={() => setMenuLang(!displayMenuLang)}>
-								<IconContext.Provider value={{ style: {fontSize: "20px"} }}>
+								<IconContext.Provider value={{ style: { fontSize: "20px" } }}>
 									<HiTranslate />
 								</IconContext.Provider>
 							</button>
@@ -419,7 +419,7 @@ const MenuUser = () => {
 		// Here we broadcast logout, in order to redirect other tabs to login page!
 		broadcastLogout();
 		window.location.href = "/j_spring_security_logout";
-	}
+	};
 	return (
 		<ul className="dropdown-ul">
 			<li>

src/components/NavBar.tsx

@@ -52,13 +52,13 @@ const NavBar = ({
 	const newResourceModalRef = useRef<ModalHandle>(null);
 
 	const showNewResourceModal = async () => {
-		create && create.onShowModal && await create.onShowModal()
-		newResourceModalRef.current?.open()
+		create && create.onShowModal && await create.onShowModal();
+		newResourceModalRef.current?.open();
 	};
 
 	const hideNewResourceModal = () => {
-		create && create.onHideModal && create.onHideModal()
-		newResourceModalRef.current?.close?.()
+		create && create.onHideModal && create.onHideModal();
+		newResourceModalRef.current?.close?.();
 	};
 
 	const toggleNavigation = () => {
@@ -69,7 +69,7 @@ const NavBar = ({
 		(create && create.hotkeySequence) ?? [],
 		() => showNewResourceModal(),
 		{ description: create && create.hotkeyDescription ? t(create.hotkeyDescription) : undefined },
-		[showNewResourceModal]
+		[showNewResourceModal],
 	);
 
 	return (
@@ -96,7 +96,7 @@ const NavBar = ({
 						>
 							{t(link.text)}
 						</Link>
-					))
+					));
 				})}
 			</nav>
 

src/components/configuration/Themes.tsx

@@ -56,7 +56,7 @@ const Themes = () => {
 		return () => {
 			allowLoadIntoTable = false;
 			clearInterval(fetchThemesInterval);
-		}
+		};
 		// eslint-disable-next-line react-hooks/exhaustive-deps
 	}, []);
 
@@ -70,7 +70,7 @@ const Themes = () => {
 					{
 						path: "/configuration/themes",
 						accessRole: "ROLE_UI_THEMES_VIEW",
-						text: "CONFIGURATION.NAVIGATION.THEMES"
+						text: "CONFIGURATION.NAVIGATION.THEMES",
 					},
 				]}
 				create={{

src/components/configuration/partials/ThemesDateTimeCell.tsx

@@ -7,7 +7,7 @@ import { ThemeDetailsType } from "../../../slices/themeSlice";
  * This component renders the creation date cells of themes in the table view
  */
 const ThemesDateTimeCell = ({
-	row
+	row,
 }: {
 	row: ThemeDetailsType
 }) => {

src/components/configuration/partials/wizard/BumperPage.tsx

@@ -22,7 +22,7 @@ const BumperPage = <T extends RequiredFormProps>({
 	nextPage,
 	previousPage,
 	isTrailer,
-	isEdit
+	isEdit,
 }: {
 	formik: FormikProps<T>,
 	nextPage?: (values: T) => void,
@@ -39,7 +39,7 @@ const BumperPage = <T extends RequiredFormProps>({
 					{t(
 						!isTrailer
 							? "CONFIGURATION.THEMES.DETAILS.BUMPER.DESCRIPTION"
-							: "CONFIGURATION.THEMES.DETAILS.TRAILER.DESCRIPTION"
+							: "CONFIGURATION.THEMES.DETAILS.TRAILER.DESCRIPTION",
 					)}
 				</p>
 				{/* notifications */}
@@ -49,7 +49,7 @@ const BumperPage = <T extends RequiredFormProps>({
 						{t(
 							!isTrailer
 								? "CONFIGURATION.THEMES.DETAILS.BUMPER.ACTIVE"
-								: "CONFIGURATION.THEMES.DETAILS.TRAILER.ACTIVE"
+								: "CONFIGURATION.THEMES.DETAILS.TRAILER.ACTIVE",
 						)}
 					</header>
 					<div className="obj-container content-list padded">
@@ -59,7 +59,7 @@ const BumperPage = <T extends RequiredFormProps>({
 									{t(
 										!isTrailer
 											? "CONFIGURATION.THEMES.DETAILS.BUMPER.ENABLE"
-											: "CONFIGURATION.THEMES.DETAILS.TRAILER.ENABLE"
+											: "CONFIGURATION.THEMES.DETAILS.TRAILER.ENABLE",
 									)}
 								</label>
 							</div>
@@ -85,7 +85,7 @@ const BumperPage = <T extends RequiredFormProps>({
 							{t(
 								!isTrailer
 									? "CONFIGURATION.THEMES.DETAILS.BUMPER.SELECT"
-									: "CONFIGURATION.THEMES.DETAILS.TRAILER.SELECT"
+									: "CONFIGURATION.THEMES.DETAILS.TRAILER.SELECT",
 							)}
 						</header>
 						<div className="obj-container padded">

src/components/configuration/partials/wizard/NewThemeWizard.tsx

@@ -16,7 +16,7 @@ import { postNewTheme, ThemeDetailsInitialValues } from "../../../../slices/them
  * This component manages the pages of the new theme wizard and the submission of values
  */
 const NewThemeWizard = ({
-	close
+	close,
 }: {
 	close: () => void
 }) => {
@@ -80,10 +80,10 @@ const NewThemeWizard = ({
 			<Formik
 				initialValues={snapshot}
 				validationSchema={currentValidationSchema}
-				onSubmit={(values) => handleSubmit(values)}
+				onSubmit={values => handleSubmit(values)}
 			>
 				{/* Render wizard pages depending on current value of page variable */}
-				{(formik) => {
+				{formik => {
 					// eslint-disable-next-line react-hooks/rules-of-hooks
 					useEffect(() => {
 						formik.validateForm();

src/components/configuration/partials/wizard/ThemeDetails.tsx

@@ -91,7 +91,7 @@ const ThemeDetails = ({
 
 	// update theme
 	const handleSubmit = (values: ThemeDetailsInitialValues) => {
-		dispatch(updateThemeDetails({id: themeDetails.id, values: values}));
+		dispatch(updateThemeDetails({ id: themeDetails.id, values: values }));
 		close();
 	};
 
@@ -108,10 +108,10 @@ const ThemeDetails = ({
 			<Formik
 				initialValues={initialValues}
 				validationSchema={currentValidationSchema}
-				onSubmit={(values) => handleSubmit(values)}
+				onSubmit={values => handleSubmit(values)}
 			>
 				{/* render modal pages depending on current value of page variable */}
-				{(formik) => (
+				{formik => (
 					<div>
 						{page === 0 && <GeneralPage formik={formik} isEdit />}
 						{page === 1 && <BumperPage formik={formik} isEdit />}