OC.RO cache size "Not specified" is exported as "other"

[following5]

The internal size ID 1 is currently definied in this way at OC sites:

DE: "other size" (= Groundspeak "Other")
RO: "Not specified" (= Groundspeak "Not chosen")
PL, NL, UK, US: undefinied

OCPL and OKAPI GPX maps ID 1 to "Other", but the correct mapping for "Not specified" would be "Not chosen".

OKAPI size2 does not have the option "not specified" and also maps it to "other". A new field size3 would be needed to map it precisely.

@andrixnet
Did you intentionally define the ID 1 as "Not specified", or did you maybe want to add the size "Other", which is also missing at the other OCPL sites?

If it was intentional: What do you think of changing the ID to 9, so that 1 may be used for "Other"? This would need some change in OCPL search.php code and template; I could do that.

[following5]

So far there are only 6 of those caches at Opencaching.RO, and only one of them was logged.

[andrixnet]

I believe the thinking behind it is as follows:

• other = a size different then the predefined sizes or not accurately describeable by the predefined sizes.

Example: 2L birdhouse as the cache hideout, but the cache itself is a kinder egg inside.
Would you say it's a regular? I think not. The outer shell is big enough, but not the log container itself.
Would you say it's a micro? I think not. Anyone searching would look explicitely for a micro sized container and will more readily discard the birdhouse as part of the cache.

• not chosen / not specified = owner explicitely does not want to convey any size information about the cache, adding to the difficulty perhaps.

So: OCDE other != OCRO not specified.

Differences in translation strings we can harmonize and we should update https://wiki.opencaching.eu/index.php?title=Cache_sizes as well.

[andrixnet]

Considering the fact that GS also dropped "not chosen" option, but has retained "other", in addition to the discussion above, I propose the following:

Consider DE-branch other = PL-branch other.
I'll take care about harmonizing the translations and document things at the wiki.

Then both branches will effectively support the same set of cache sizes and:

In Okapi.php line 1064:

    public static function get_local_cachesizes()
    {
        # OCPL only knows a subset of sizes, which is defined in the
        # GeoCacheCommons class. OCDE supports all sizes; they are listed
        # in the 'cache_size' table.

        if (Settings::get('OC_BRANCH') == 'oc.pl')
        {
            return ['none', 'micro', 'small', 'regular', 'large', 'xlarge'];
        }
        else
        {
            return array_keys(self::$cache_sizes);
        }
    }

opencaching-pl supports all 8 sizes:
https://github.com/opencaching/opencaching-pl/blob/5d34b09e50e41119b52e2682cb43d99cd55eb00d/src/Models/GeoCache/GeoCacheCommons.php#L32

IMO OKAPI no longer needs that exception, in fact it should be removed to properly support the full range of PL-branch sizes.