Merge pull request #618 from opencaching/php7.4-compat

PHP7.4 compat - replace create_function by anonymous function

Author: deg-pl

okapi/services/caches/search/SearchAssistant.php

@@ -427,7 +427,7 @@ public function prepare_common_search_params()
                 throw new InvalidParam('found_by', $e->whats_wrong_about_it);
             }
 
-            $internal_user_ids = array_map(create_function('$user', 'return $user["internal_id"];'), $users);
+            $internal_user_ids = array_map(function ($user) { return $user["internal_id"]; }, $users);
             if (Settings::get('USE_SQL_SUBQUERIES')) {
                 $found_cache_subquery = self::get_found_cache_ids_subquery($internal_user_ids);
                 $where_conds[] = "caches.cache_id in (".$found_cache_subquery.")";
@@ -450,7 +450,7 @@ public function prepare_common_search_params()
                 throw new InvalidParam('not_found_by', $e->whats_wrong_about_it);
             }
 
-            $internal_user_ids = array_map(create_function('$user', 'return $user["internal_id"];'), $users);
+            $internal_user_ids = array_map(function ($user) { return $user["internal_id"]; }, $users);
             if (Settings::get('USE_SQL_SUBQUERIES')) {
                 $found_cache_subquery = self::get_found_cache_ids_subquery($internal_user_ids);
                 $where_conds[] = "caches.cache_id not in (".$found_cache_subquery.")";
@@ -485,7 +485,7 @@ public function prepare_common_search_params()
             } catch (InvalidParam $e) { # too many uuids
                 throw new InvalidParam('not_found_by', $e->whats_wrong_about_it);
             }
-            $internal_user_ids = array_map(create_function('$user', 'return $user["internal_id"];'), $users);
+            $internal_user_ids = array_map(function ($user) { return $user["internal_id"]; }, $users);
             $where_conds[] = self::get_recommended_by_sql($internal_user_ids);
         }