Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Commit dabfb16

Browse files
authored
Merge pull request #1392 from binwiederhier/docs-update
Minor, but relevant docs updates
2 parents c846d43 + 2582f1f commit dabfb16

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

docs/configuration-discovery-classifying.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -90,21 +90,21 @@ This behavior can be controlled by the following options:
9090
and `MasterWithTooManyReplicas` will enable _and disable_ semi-sync on the replicas to match the desired topology exactly based on the priority order.
9191
- `RecoverLockedSemiSyncMaster`: flag that decides whether to recover from a `LockedSemiSyncMaster` scenario. If enabled, the recovery of `LockedSemiSyncMaster`
9292
will enable _(but never disable)_ semi-sync on the replicas in the priority order to match the master wait count. This option has no effect if
93-
`EnforceExactSemiSyncReplicas` is set. It is only useful if you'd like to only handle a situation which which there are too few semi-sync replicas,
93+
`EnforceExactSemiSyncReplicas` is set. It is useful if you'd like to only handle a situation in which there are too few semi-sync replicas,
9494
but not if there are too many.
9595
- `ReasonableLockedSemiSyncMasterSeconds`: number of seconds after which the `LockedSemiSyncMaster` condition is triggered; if not set, falls back to `ReasonableReplicationLagSeconds`
9696

9797
The priority order is defined by `DetectSemiSyncEnforcedQuery` (zero means async replica; higher number is higher priority), the promotion rule (`DetectPromotionRuleQuery`)
9898
and the hostname (fallback).
9999

100-
**Example 1**: Enforcing a strict semi-sync replica topology with two replicas and `rpl_semi_sync_master_wait_for_slave_count=1`:
100+
**Example 1**: Enforcing a strict semi-sync replica topology, with `rpl_semi_sync_master_wait_for_slave_count=1`:
101101

102102
```
103103
"DetectSemiSyncEnforcedQuery": "select priority from meta.semi_sync where cluster_member = @@hostname",
104104
"EnforceExactSemiSyncReplicas": true
105105
```
106106

107-
Assuming this topology:
107+
Assuming this topology,
108108

109109
```
110110
,- replica1 (priority = 10, rpl_semi_sync_slave_enabled = 1)
@@ -113,17 +113,17 @@ Assuming this topology:
113113
```
114114

115115
`orchestrator` would detect a [`MasterWithTooManySemiSyncReplicas`](failure-detection.md#masterwithtoomanysemisyncreplicas) scenario
116-
and disable semi-sync on replica2.
116+
and disable semi-sync on replica1 (lower priority).
117117

118-
**Example 2**: Enforcing a weak semi-sync replica toplogy with two replicas and `rpl_semi_sync_master_wait_for_slave_count=1`:
118+
**Example 2**: Enforcing a weak semi-sync replica toplogy, with `rpl_semi_sync_master_wait_for_slave_count=1`:
119119

120120
```
121121
"DetectSemiSyncEnforcedQuery": "select 2586",
122122
"DetectPromotionRuleQuery": "select promotion_rule from meta.promotion_rules where cluster_member = @@hostname",
123123
"RecoverLockedSemiSyncMaster": true
124124
```
125125

126-
Assuming this topology:
126+
Assuming this topology,
127127

128128
```
129129
,- replica1 (priority = 2586, promotion rule = prefer, rpl_semi_sync_slave_enabled = 0)
@@ -132,4 +132,4 @@ Assuming this topology:
132132
```
133133

134134
`orchestrator` would detect a [`LockedSemiSyncMaster`](failure-detection.md#lockedsemisyncmaster) scenario
135-
and enable semi-sync on replica1.
135+
and enable semi-sync on replica1 (more preferable promotion rule).

docs/failure-detection.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ This scenario can happen when the master is overloaded. Clients would see a "Too
104104
3. `rpl_semi_sync_master_timeout` is high enough such that master locks writes and does not fall back to asynchronous replication
105105

106106
This condition only triggers after `ReasonableLockedSemiSyncMasterSeconds` has passed. If `ReasonableLockedSemiSyncMasterSeconds` is not set,
107-
it trigger after `ReasonableReplicationLagSeconds`.
107+
it triggers after `ReasonableReplicationLagSeconds`.
108108

109109
Remediation of this condition can be to disable semi-sync on the master, or to bring up (or enable) sufficient semi-sync replicas.
110110

0 commit comments

Comments
 (0)