MySQL backend does not use context.WithTimeout

shlomi-noach · shlomi-noach · commit 08f898fcfa74 · 2021-05-06T19:31:15.000+03:00
Signed-off-by: Shlomi Noach &lt;2607934+shlomi-noach@users.noreply.github.com&gt;
diff --git a/go/db/db.go b/go/db/db.go
@@ -382,8 +382,7 @@ func ExecOrchestrator(query string, args ...interface{}) (sql.Result, error) {
 	if err != nil {
 		return nil, err
 	}
-	ctx, cancel := context.WithTimeout(context.Background(), time.Duration(config.Config.MySQLOrchestratorReadTimeoutSeconds)*time.Second)
-	defer cancel()
+	ctx := context.Background()
 	res, err := sqlutils.ExecNoPrepare(ctx, db, query, args...)
 	return res, err
 }

Original file line number	Diff line number	Diff line change
`@@ -382,8 +382,7 @@ func ExecOrchestrator(query string, args ...interface{}) (sql.Result, error) {`
`382`	`382`	`if err != nil {`
`383`	`383`	`return nil, err`
`384`	`384`	`}`
`385`		`- ctx, cancel := context.WithTimeout(context.Background(), time.Duration(config.Config.MySQLOrchestratorReadTimeoutSeconds)*time.Second)`
`386`		`- defer cancel()`
	`385`	`+ ctx := context.Background()`
`387`	`386`	`res, err := sqlutils.ExecNoPrepare(ctx, db, query, args...)`
`388`	`387`	`return res, err`
`389`	`388`	`}`