Created an adapter and source for Trento in Italy #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Contributor
|
@russbiggs I am recommending to merge this PR, source and adapter appear to be working well. We may want this in master and not just merged to develop |
Member
|
@majesticio so it looks like we are getting some locations in Trento, via the EEA adapter. Does this PR add more locations that we dont have? Would there be overlap with the existing locations? Ideally for EU we've preferred data from EEA instead of these kinds of regional data sources, since EEA tends to have everything in one API. If there is something different though we should explore. |
Contributor
|
I think it adds 6 more stations. Looks like 3 might overlap, I'm going to double check them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an adapter for Trento Region in Italy,
this source has around 9 stations, and 28 different sensors.
This source updates daily, with mostly information from the day before.
Closes #420