Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray Version? #2

Open
jhpenger opened this issue Oct 30, 2018 · 4 comments
Open

Ray Version? #2

jhpenger opened this issue Oct 30, 2018 · 4 comments

Comments

@jhpenger
Copy link

What version of ray should I use for this?

@robertnishihara
Copy link
Contributor

I believe 0.4.0. But you could also try the latest version of Ray.

@jhpenger
Copy link
Author

jhpenger commented Oct 31, 2018

Works for 0.4.0. But:
I'm not able to train it under current ray version: 0.5.3 after I updated the old config parameters to their appropriate names.
I am getting an error in tensorflow 2Dconv:

ValueError: Negative dimension size caused by subtracting 11 from 10 for 'default/vision_net/fc1/Conv2D' (op: 'Conv2D') with input shapes: [?,10,10,32], [11,11,32,256].

@robertnishihara
Copy link
Contributor

Ok, good to know! It was initially tested with 0.4.0.

@jhpenger
Copy link
Author

@robertnishihara Can you please check visionnet.py on the main repo? line 54 & 59
Were changed from [256, [10, 10], 1] to [256, [11, 11], 1] on ray-project/ray#2679
Those 2 default conv filters with 11s instead of 10s was the cause of the conv2D error.
Was able to get sonic-on-ray working when I changed the kernel from [11, 11] back to [10, 10].
Any thoughts on what went wrong there?
and what conv filters did you use for this originally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants