Skip to content

Commit 9deb8ce

Browse files
authored
Move sandbox policy transforms into codex-sandboxing (#15599)
## Summary - move the pure sandbox policy transform helpers from `codex-core` into `codex-sandboxing` - move the corresponding unit tests with the extracted implementation - update `core` and `app-server` callers to import the moved APIs directly, without re-exports or proxy methods ## Testing - cargo test -p codex-sandboxing - cargo test -p codex-core sandboxing - cargo test -p codex-app-server --lib - just fix -p codex-sandboxing - just fix -p codex-core - just fix -p codex-app-server - just fmt - just argument-comment-lint
1 parent a10960e commit 9deb8ce

File tree

14 files changed

+1020
-980
lines changed

14 files changed

+1020
-980
lines changed

codex-rs/Cargo.lock

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

codex-rs/app-server/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ codex-protocol = { workspace = true }
4646
codex-app-server-protocol = { workspace = true }
4747
codex-feedback = { workspace = true }
4848
codex-rmcp-client = { workspace = true }
49+
codex-sandboxing = { workspace = true }
4950
codex-state = { workspace = true }
5051
codex-utils-absolute-path = { workspace = true }
5152
codex-utils-json-to-toml = { workspace = true }

codex-rs/app-server/src/bespoke_event_handling.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ use codex_core::ThreadManager;
110110
use codex_core::find_thread_name_by_id;
111111
use codex_core::review_format::format_review_findings_block;
112112
use codex_core::review_prompts;
113-
use codex_core::sandboxing::intersect_permission_profiles;
114113
use codex_protocol::ThreadId;
115114
use codex_protocol::dynamic_tools::DynamicToolCallOutputContentItem as CoreDynamicToolCallOutputContentItem;
116115
use codex_protocol::dynamic_tools::DynamicToolResponse as CoreDynamicToolResponse;
@@ -136,6 +135,7 @@ use codex_protocol::request_permissions::RequestPermissionProfile as CoreRequest
136135
use codex_protocol::request_permissions::RequestPermissionsResponse as CoreRequestPermissionsResponse;
137136
use codex_protocol::request_user_input::RequestUserInputAnswer as CoreRequestUserInputAnswer;
138137
use codex_protocol::request_user_input::RequestUserInputResponse as CoreRequestUserInputResponse;
138+
use codex_sandboxing::policy_transforms::intersect_permission_profiles;
139139
use codex_shell_command::parse_command::shlex_join;
140140
use std::collections::HashMap;
141141
use std::convert::TryFrom;

0 commit comments

Comments
 (0)