Add test: weird order of iterations

Author: franzpoeschel

src/Series.cpp

@@ -1597,7 +1597,7 @@ SeriesInternal::~SeriesInternal()
          * needlessly flushed a second time. Otherwise, error messages can get
          * very confusing.
          */
-        if( get().m_lastFlushSuccessful )
+        if( series.m_lastFlushSuccessful )
         {
             flush();
             flushStep( /* doFlush = */ true );

test/SerialIOTest.cpp

@@ -4564,11 +4564,9 @@ TEST_CASE( "deferred_parsing", "[serial]" )
     }
 }
 
-// @todo merge this back with the chaotic_stream test of PR #949
-// (bug noticed while working on that branch)
-void no_explicit_flush( std::string filename )
+void chaotic_stream( std::string filename, bool variableBased )
 {
-    std::vector< uint64_t > sampleData{ 5, 9, 1, 3, 4, 6, 7, 8, 2, 0 };
+    std::vector< uint64_t > iterations{ 5, 9, 1, 3, 4, 6, 7, 8, 2, 0 };
     std::string jsonConfig = R"(
 {
     "adios2": {
@@ -4580,16 +4578,31 @@ void no_explicit_flush( std::string filename )
     }
 })";
 
+    bool weirdOrderWhenReading{};
+
     {
         Series series( filename, Access::CREATE, jsonConfig );
-        for( uint64_t currentIteration = 0; currentIteration < 10;
-             ++currentIteration )
+        /*
+         * When using ADIOS2 steps, iterations are read not by logical order
+         * (iteration index), but by order of writing.
+         */
+        weirdOrderWhenReading = series.backend() == "ADIOS2" &&
+            series.iterationEncoding() != IterationEncoding::fileBased;
+        if( variableBased )
+        {
+            if( series.backend() != "ADIOS2" )
+            {
+                return;
+            }
+            series.setIterationEncoding( IterationEncoding::variableBased );
+        }
+        for( auto currentIteration : iterations )
         {
             auto dataset =
                 series.writeIterations()[ currentIteration ]
                     .meshes[ "iterationOrder" ][ MeshRecordComponent::SCALAR ];
             dataset.resetDataset( { determineDatatype< uint64_t >(), { 10 } } );
-            dataset.storeChunk( sampleData, { 0 }, { 10 } );
+            dataset.storeChunk( iterations, { 0 }, { 10 } );
             // series.writeIterations()[ currentIteration ].close();
         }
     }
@@ -4599,19 +4612,27 @@ void no_explicit_flush( std::string filename )
         size_t index = 0;
         for( auto iteration : series.readIterations() )
         {
-            REQUIRE( iteration.iterationIndex == index );
+            if( weirdOrderWhenReading )
+            {
+                REQUIRE( iteration.iterationIndex == iterations[ index ] );
+            }
+            else
+            {
+                REQUIRE( iteration.iterationIndex == index );
+            }
             ++index;
         }
-        REQUIRE( index == 10 );
+        REQUIRE( index == iterations.size() );
     }
 }
 
-TEST_CASE( "no_explicit_flush", "[serial]" )
+TEST_CASE( "chaotic_stream", "[serial]" )
 {
     for( auto const & t : testedFileExtensions() )
     {
-        no_explicit_flush( "../samples/no_explicit_flush_filebased_%T." + t );
-        no_explicit_flush( "../samples/no_explicit_flush." + t );
+        chaotic_stream( "../samples/chaotic_stream_filebased_%T." + t, false );
+        chaotic_stream( "../samples/chaotic_stream." + t, false );
+        chaotic_stream( "../samples/chaotic_stream_vbased." + t, true );
     }
 }