Test APPEND mode in all backends for groupbased Series

Author: franzpoeschel

include/openPMD/openPMD.hpp

@@ -27,6 +27,7 @@ namespace openPMD {}
 // IWYU pragma: begin_exports
 #include "openPMD/Dataset.hpp"
 #include "openPMD/Datatype.hpp"
+#include "openPMD/Error.hpp"
 #include "openPMD/IterationEncoding.hpp"
 #include "openPMD/Iteration.hpp"
 #include "openPMD/Mesh.hpp"

test/SerialIOTest.cpp

@@ -3980,8 +3980,17 @@ void append_mode( std::string const & extension )
     {
         Series write(
             "../samples/append." + extension, Access::APPEND, jsonConfig );
+        if( write.backend() == "ADIOS1" )
+        {
+            REQUIRE_THROWS_AS(
+                write.flush(), error::OperationUnsupportedInBackend );
+            // destructor will be noisy now
+            return;
+        }
+
         writeSomeIterations(
             write.writeIterations(), std::vector< uint64_t >{ 2, 3 } );
+        write.flush();
     }
     {
         Series read( "../samples/append." + extension, Access::READ_ONLY );
@@ -3991,8 +4000,8 @@ void append_mode( std::string const & extension )
 
 TEST_CASE( "append_mode", "[serial]" )
 {
-    // @todo test for file-based appending
-    append_mode( "json" );
-    // append_mode( "bp" );
-    //append_mode( "h5" );
+    for( auto const & t : testedFileExtensions() )
+    {
+        append_mode( t );
+    }
 }