Skip to content

Commit 76b6f05

Browse files
franzpoeschelax3l
andcommitted
Apply suggestions from code review
Co-authored-by: Axel Huebl <[email protected]>
1 parent 56bfa04 commit 76b6f05

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/Error.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ namespace error
4747
{}
4848

4949
Internal::Internal(std::string const &what)
50-
: Error("Internal error: " + what + "\nThis is a bug. Please report.")
50+
: Error(
51+
"Internal error: " + what +
52+
"\nThis is a bug. Please report at ' "
53+
"https://github.com/openPMD/openPMD-api/issues'.")
5154
{}
5255
} // namespace error
5356
} // namespace openPMD

src/IO/HDF5/HDF5IOHandler.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,8 @@ void HDF5IOHandlerImpl::createFile(
258258
break;
259259
case Access::READ_ONLY:
260260
// condition has been checked above
261-
throw std::runtime_error("Control flow error");
261+
throw std::runtime_error(
262+
"[HDF5] Control flow error in createFile backend access mode.");
262263
}
263264

264265
hid_t id{};
@@ -470,8 +471,8 @@ void HDF5IOHandlerImpl::createDataset(
470471
status = H5Ldelete(node_id, name.c_str(), H5P_DEFAULT);
471472
VERIFY(
472473
status == 0,
473-
"[HDF5] Internal error: Failed to delete old dataset from "
474-
"group for overwriting.");
474+
"[HDF5] Internal error: Failed to delete old dataset '" +
475+
name + "' from group for overwriting.");
475476
break;
476477
}
477478
}

0 commit comments

Comments
 (0)