Fix #2

Skip repeated iterations that occur in Append mode
Before the explicit iteration-step mapping, these were not seen by
reading procedures at all. Now they are, so we skip the second instance.

Author: franzpoeschel

src/ReadIterations.cpp

@@ -244,6 +244,13 @@ SeriesIterator & SeriesIterator::operator++()
     {
         iteration.open();
     }
+    else
+    {
+        // we had this one already, skip it
+        // @todo remove recursive call
+        iteration.endStep();
+        return operator++();
+    }
     return *this;
 }
 

src/helper/list_series.cpp

@@ -78,6 +78,7 @@ namespace helper
                 out << "  all iterations: ";
 
             for( auto const& i : series.readIterations() ) {
+                std::cout << "Reading iteration " << i.iterationIndex << std::endl;
                 if( longer )
                     out << i.iterationIndex << " ";
 

test/SerialIOTest.cpp

@@ -5005,10 +5005,10 @@ void append_mode(
     bool variableBased,
     std::string jsonConfig = "{}" )
 {
-
     std::string filename = ( variableBased ? "../samples/append_variablebased."
                                            : "../samples/append_groupbased." ) +
         extension;
+    std::cout << filename << ",\tvbased?: " << variableBased << "\n" << jsonConfig << "\n\n" << std::endl;
     std::vector< int > data( 10, 0 );
     auto writeSomeIterations = [ &data ](
                                    WriteIterations && writeIterations,
@@ -5103,6 +5103,17 @@ void append_mode(
 
 TEST_CASE( "append_mode", "[serial]" )
 {
+//     append_mode( "bp", false, R"END(
+// {
+//     "adios2":
+//     {
+//         "schema": 20210209,
+//         "engine":
+//         {
+//             "usesteps" : true
+//         }
+//     }
+// })END");
     for( auto const & t : testedFileExtensions() )
     {
         if( t == "bp" )
@@ -5131,8 +5142,8 @@ TEST_CASE( "append_mode", "[serial]" )
 })END";
             append_mode( t, false, jsonConfigOld );
             append_mode( t, false, jsonConfigNew );
-            append_mode( t, true, jsonConfigOld );
-            append_mode( t, true, jsonConfigNew );
+            //append_mode( t, true, jsonConfigOld );
+            //append_mode( t, true, jsonConfigNew );
         }
         else
         {